Skip to content

Commit 1193290

Browse files
authored
deps: V8: cherry-pick cc9a8a37445e
Original commit message: fix overflow check in error formatting Bug: v8:12494 Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Gus Caplan <[email protected]> Cr-Commit-Position: refs/heads/main@{#78909} Refs: v8/v8@cc9a8a3 PR-URL: #42065 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
1 parent a35f553 commit 1193290

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
# Reset this number to 0 on major V8 upgrades.
3636
# Increment by one for each non-official patch applied to deps/v8.
37-
'v8_embedder_string': '-node.56',
37+
'v8_embedder_string': '-node.57',
3838

3939
##### V8 defaults for Node.js #####
4040

deps/v8/src/execution/messages.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -823,7 +823,8 @@ MaybeHandle<Object> ErrorUtils::FormatStackTrace(Isolate* isolate,
823823
Handle<FixedArray> elems = Handle<FixedArray>::cast(raw_stack);
824824

825825
const bool in_recursion = isolate->formatting_stack_trace();
826-
if (!in_recursion) {
826+
const bool has_overflowed = i::StackLimitCheck{isolate}.HasOverflowed();
827+
if (!in_recursion && !has_overflowed) {
827828
Handle<Context> error_context = error->GetCreationContext();
828829
DCHECK(error_context->IsNativeContext());
829830

0 commit comments

Comments
 (0)