Skip to content

Commit 1bd0e78

Browse files
committed
test
1 parent 85c517f commit 1bd0e78

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

doc/contributing/maintaining-V8.md

+11-10
Original file line numberDiff line numberDiff line change
@@ -208,11 +208,11 @@ backport the fix:
208208
Abandoned V8 branches are supported in the Node.js repository. The fix needs
209209
to be cherry-picked in the Node.js repository and V8-CI must test the change.
210210

211-
As an example for how to backport changes, consider the bug [RegExp show
212-
inconsistent result with other browsers](https://crbug.com/v8/5199). From the
213-
bug we can see that it was merged by V8 into 5.2 and 5.3, and not into V8 5.1
214-
(since it was already abandoned). Since Node.js `v6.x` uses V8 5.1, the fix
215-
needed to be backported.
211+
As an example for how to backport changes, consider the bug
212+
[RegExp show inconsistent result with other browsers](https://crbug.com/v8/5199).
213+
From the bug we can see that it was merged by V8 into 5.2 and 5.3, and not into
214+
V8 5.1 (since it was already abandoned). Since Node.js `v6.x` uses V8 5.1, the
215+
fix needed to be backported.
216216

217217
#### Backporting with `git-node` (recommended)
218218

@@ -227,9 +227,7 @@ Here are the steps for the bug mentioned above:
227227
4. Checkout a branch off the appropriate _vY.x-staging_ branch (e.g.
228228
_v6.x-staging_ to fix an issue in V8 5.1).
229229
5. Run `git node v8 backport a51f429`.
230-
6. If there are conflicts, `git-node` will wait for you to resolve them.
231-
`git-node` will prompt you to resolve them in another terminal and then
232-
enter `RESOLVED`:
230+
6. If there are conflicts, `git-node` will wait for you to resolve them:
233231

234232
```console
235233
$ git node v8 backport a51f429
@@ -245,6 +243,9 @@ $ git node v8 backport a51f429
245243

246244
? Resolve merge conflicts and enter 'RESOLVED' ‣
247245
```
246+
Resolve conflicts by opening another terminal and staging resolutions
247+
to the merge conflicts. Once you fixed the conflicts, return to
248+
`git-node` and enter `RESOLVED`.
248249

249250
7. After you resolve conflicts (or if there are no conflicts), the
250251
output should look like this:
@@ -262,7 +263,7 @@ $ git node v8 backport a51f429
262263

263264
See [`git-node-v8-backport`][] for more documentation and additional options.
264265

265-
#### Backporting manually (not recommended)
266+
#### Backporting manually
266267

267268
* For each abandoned V8 branch corresponding to an LTS branch that is affected
268269
by the bug:
@@ -379,7 +380,7 @@ that Node.js may be floating (or else cause a merge conflict).
379380

380381
See [`git-node-v8-minor`][] for more documentation and additional options.
381382

382-
#### Applying minor updates manually (not recommended)
383+
#### Applying minor updates manually
383384

384385
The rough outline of the process is:
385386

0 commit comments

Comments
 (0)