@@ -208,11 +208,11 @@ backport the fix:
208
208
Abandoned V8 branches are supported in the Node.js repository. The fix needs
209
209
to be cherry-picked in the Node.js repository and V8-CI must test the change.
210
210
211
- As an example for how to backport changes, consider the bug [ RegExp show
212
- inconsistent result with other browsers] ( https://crbug.com/v8/5199 ) . From the
213
- bug we can see that it was merged by V8 into 5.2 and 5.3, and not into V8 5.1
214
- (since it was already abandoned). Since Node.js ` v6.x ` uses V8 5.1, the fix
215
- needed to be backported.
211
+ As an example for how to backport changes, consider the bug
212
+ [ RegExp show inconsistent result with other browsers] ( https://crbug.com/v8/5199 ) .
213
+ From the bug we can see that it was merged by V8 into 5.2 and 5.3, and not into
214
+ V8 5.1 (since it was already abandoned). Since Node.js ` v6.x ` uses V8 5.1, the
215
+ fix needed to be backported.
216
216
217
217
#### Backporting with ` git-node ` (recommended)
218
218
@@ -227,9 +227,7 @@ Here are the steps for the bug mentioned above:
227
227
4 . Checkout a branch off the appropriate _ vY.x-staging_ branch (e.g.
228
228
_ v6.x-staging_ to fix an issue in V8 5.1).
229
229
5 . Run ` git node v8 backport a51f429 ` .
230
- 6 . If there are conflicts, ` git-node ` will wait for you to resolve them.
231
- ` git-node ` will prompt you to resolve them in another terminal and then
232
- enter ` RESOLVED ` :
230
+ 6 . If there are conflicts, ` git-node ` will wait for you to resolve them:
233
231
234
232
``` console
235
233
$ git node v8 backport a51f429
@@ -245,6 +243,9 @@ $ git node v8 backport a51f429
245
243
246
244
? Resolve merge conflicts and enter 'RESOLVED' ‣
247
245
```
246
+ Resolve conflicts by opening another terminal and staging resolutions
247
+ to the merge conflicts. Once you fixed the conflicts, return to
248
+ ` git-node ` and enter ` RESOLVED ` .
248
249
249
250
7 . After you resolve conflicts (or if there are no conflicts), the
250
251
output should look like this:
@@ -262,7 +263,7 @@ $ git node v8 backport a51f429
262
263
263
264
See [ ` git-node-v8-backport ` ] [ ] for more documentation and additional options.
264
265
265
- #### Backporting manually (not recommended)
266
+ #### Backporting manually
266
267
267
268
* For each abandoned V8 branch corresponding to an LTS branch that is affected
268
269
by the bug:
@@ -379,7 +380,7 @@ that Node.js may be floating (or else cause a merge conflict).
379
380
380
381
See [ ` git-node-v8-minor ` ] [ ] for more documentation and additional options.
381
382
382
- #### Applying minor updates manually (not recommended)
383
+ #### Applying minor updates manually
383
384
384
385
The rough outline of the process is:
385
386
0 commit comments