Skip to content

Commit 4ced007

Browse files
author
Salame William
committed
doc: moved links about PR communication to COLLABORATOR_GUIDE.md
Moved a few links about PR communication from CONTRIBUTING.md to COLLABORATOR_GUIDE.md
1 parent 670ddfd commit 4ced007

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

COLLABORATOR_GUIDE.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,11 @@ oppose the PR, it can be landed. Where there is disagreement among TSC members
116116
or objections from one or more Collaborators, `semver-major` pull requests
117117
should be put on the TSC meeting agenda.
118118

119+
#### Helpful resources
120+
121+
* How to respectfully and usefully review code, part [one](https://mtlynch.io/human-code-reviews-1/) and [two](https://mtlynch.io/human-code-reviews-2/)
122+
* [How to write a positive code review](https://css-tricks.com/code-review-etiquette/)
123+
119124
### Waiting for Approvals
120125

121126
Before landing pull requests, sufficient time should be left for input

CONTRIBUTING.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -828,8 +828,6 @@ The following additional resources may be of assistance:
828828
* [How to create a Minimal, Complete, and Verifiable example](https://stackoverflow.com/help/mcve)
829829
* [core-validate-commit](https://github.com/evanlucas/core-validate-commit) -
830830
A utility that ensures commits follow the commit formatting guidelines.
831-
* How to respectfully and usefully review code, part [one](https://mtlynch.io/human-code-reviews-1/) and [two](https://mtlynch.io/human-code-reviews-2/)
832-
* [How to write a positive code review](https://css-tricks.com/code-review-etiquette/)
833831

834832
<a id="developers-certificate-of-origin"></a>
835833
## Developer's Certificate of Origin 1.1

0 commit comments

Comments
 (0)