Skip to content

Commit 5724b6c

Browse files
danbevMylesBorins
authored andcommitted
crypto: remove BIO_set_shutdown
I've not been able to find any reason for calling BIO_set_shutdown(bio, 1). This is done by default for the following versions of OpenSSL: https://github.com/openssl/openssl/blob/OpenSSL_1_1_0/ crypto/bio/bio_lib.c#L26 https://github.com/openssl/openssl/blob/OpenSSL_1_0_1/ crypto/bio/bio_lib.c#L90 https://github.com/openssl/openssl/blob/OpenSSL_1_0_2/ crypto/bio/bio_lib.c#L88 https://github.com/openssl/openssl/blob/OpenSSL_1_0_0/ crypto/bio/bio_lib.c#L90 This commit removes the call and the comment. Backport-PR-URL: #17784 PR-URL: #17542 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 4ca458a commit 5724b6c

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/node_crypto_bio.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ void NodeBIO::AssignEnvironment(Environment* env) {
5151
int NodeBIO::New(BIO* bio) {
5252
bio->ptr = new NodeBIO();
5353

54-
// XXX Why am I doing it?!
55-
bio->shutdown = 1;
5654
bio->init = 1;
5755
bio->num = -1;
5856

0 commit comments

Comments
 (0)