Skip to content

Commit 78e79c7

Browse files
danbevMylesBorins
authored andcommitted
test: fix deprecation warning in binding.cc
Currently, the make-callback-domain-warning addon generates the following warning: ../binding.cc:22:9: warning: 'MakeCallback' is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations] node::MakeCallback(isolate, recv, method, 0, nullptr); ^ ../../../../src/node.h:172:50: note: 'MakeCallback' has been explicitly marked deprecated here NODE_EXTERN v8::Local<v8::Value> MakeCallback( ^ 1 warning generated. This commit fixes this warning. PR-URL: #18877 Reviewed-By: Ali Ijaz Sheikh <[email protected]>
1 parent e194c37 commit 78e79c7

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

test/addons/make-callback-recurse/binding.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ void MakeCallback(const FunctionCallbackInfo<Value>& args) {
1919
Local<Object> recv = args[0].As<Object>();
2020
Local<Function> method = args[1].As<Function>();
2121

22-
node::MakeCallback(isolate, recv, method, 0, nullptr);
22+
node::MakeCallback(isolate, recv, method, 0, nullptr,
23+
node::async_context{0, 0});
2324
}
2425

2526
void Initialize(Local<Object> exports) {

0 commit comments

Comments
 (0)