http2: consider priotity weight a no-op following nghttp2 1.65.0 change

Signed-off-by: Matteo Collina <[email protected]>

Author: mcollina

doc/api/http2.md

@@ -1457,6 +1457,13 @@ numeric stream identifier.
 
 <!-- YAML
 added: v8.4.0
+deprecated:
+  - REPLACEME
+changes:
+  - version:
+      - REPLACEME
+    pr-url: REPLACEME
+    description: Following the update of nghttp2 to v1.65.0, this is now a no-op.
 -->
 
 * `options` {Object}
@@ -1473,6 +1480,7 @@ added: v8.4.0
     sending a `PRIORITY` frame to the connected peer.
 
 Updates the priority for this `Http2Stream` instance.
+The priority is ignored.
 
 #### `http2stream.rstCode`
 
@@ -1568,6 +1576,12 @@ req.setTimeout(5000, () => req.close(NGHTTP2_CANCEL));
 
 <!-- YAML
 added: v8.4.0
+changes:
+  - version:
+    - REPLACEME
+    pr-url: REPLACEME
+    description: Following the change in nghttp2 v1.65.0, the `state.weight` property is
+      now always set to 16.
 -->
 
 Provides miscellaneous information about the current state of the
@@ -1584,7 +1598,8 @@ Provides miscellaneous information about the current state of the
   * `sumDependencyWeight` {number} The sum weight of all `Http2Stream`
     instances that depend on this `Http2Stream` as specified using
     `PRIORITY` frames.
-  * `weight` {number} The priority weight of this `Http2Stream`.
+  * `weight` {number} The priority weight of this `Http2Stream`. This weight is now
+    always set to `16`.
 
 A current state of this `Http2Stream`.
 

test/parallel/test-http2-client-set-priority.js

@@ -9,7 +9,9 @@ const http2 = require('http2');
 const checkWeight = (actual, expect) => {
   const server = http2.createServer();
   server.on('stream', common.mustCall((stream, headers, flags) => {
-    assert.strictEqual(stream.state.weight, expect);
+    // Priority has been removed from nghttp2, so this is always 16
+    // starting from nghttp2 1.65.0
+    assert.strictEqual(stream.state.weight, 16);
     stream.respond();
     stream.end('test');
   }));

test/parallel/test-http2-priority-event.js

@@ -3,21 +3,13 @@
 const common = require('../common');
 if (!common.hasCrypto)
   common.skip('missing crypto');
-const assert = require('assert');
 const h2 = require('http2');
 
 const server = h2.createServer();
 
 // We use the lower-level API here
 server.on('stream', common.mustCall(onStream));
 
-function onPriority(stream, parent, weight, exclusive) {
-  assert.strictEqual(stream, 1);
-  assert.strictEqual(parent, 0);
-  assert.strictEqual(weight, 1);
-  assert.strictEqual(exclusive, false);
-}
-
 function onStream(stream, headers, flags) {
   stream.priority({
     parent: 0,
@@ -33,7 +25,7 @@ function onStream(stream, headers, flags) {
 
 server.listen(0);
 
-server.on('priority', common.mustCall(onPriority));
+server.on('priority', common.mustNotCall());
 
 server.on('listening', common.mustCall(() => {
 
@@ -48,7 +40,9 @@ server.on('listening', common.mustCall(() => {
     });
   });
 
-  req.on('priority', common.mustCall(onPriority));
+  // The priority event is not supported anymore by nghttp2
+  // since 1.65.0.
+  req.on('priority', common.mustNotCall());
 
   req.on('response', common.mustCall());
   req.resume();