Merge branch 'nodejs:main' into test-readline-interface-coverage

Author: fossamagna

.eslintrc.js

@@ -337,6 +337,7 @@ module.exports = {
     TextEncoderStream: 'readable',
     TransformStream: 'readable',
     TransformStreamDefaultController: 'readable',
+    ShadowRealm: 'readable',
     SubtleCrypto: 'readable',
     WritableStream: 'readable',
     WritableStreamDefaultWriter: 'readable',

.github/CODEOWNERS

@@ -107,10 +107,8 @@
 
 /benchmark/misc/startup.js @nodejs/startup
 /src/node.cc @nodejs/startup
-/src/node_code_cache_stub.cc @nodejs/startup
 /src/node_native_module* @nodejs/startup
 /lib/internal/bootstrap/* @nodejs/startup
-/tools/code_cache/* @nodejs/startup
 /tools/snapshot/* @nodejs/startup
 
 # V8

.github/label-pr-config.yml

@@ -67,7 +67,7 @@ subSystemLabels:
   /^tools\/make-v8/: tools, v8 engine, needs-ci
   /^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
   /^tools\/(code_cache|snapshot)/: needs-ci
-  /^tools\/build-addons.js/: needs-ci
+  /^tools\/build-addons.mjs/: needs-ci
   # all other tool changes should be marked as such
   /^tools\//: tools
   /^\.eslint|\.remark|\.editorconfig/: tools

.github/workflows/authors.yml

@@ -15,16 +15,18 @@ jobs:
         with:
           fetch-depth: '0'  # This is required to actually get all the authors
           persist-credentials: false
-      - run: tools/update-authors.js  # Run the AUTHORS tool
-      - uses: gr2m/create-or-update-pull-request-action@v1  # Create a PR or update the Action's existing PR
+      - run: tools/update-authors.mjs  # Run the AUTHORS tool
+      - uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        # Creates a PR or update the Action's existing PR, or
+        # no-op if the base branch is already up-to-date.
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:
           author: Node.js GitHub Bot <[email protected]>
           body: >
             Here are some new additions to the AUTHORS file.
             This is an automatically generated PR by the
-            `authors.yml` GitHub Action, which runs `tools/update-authors.js`.
+            `authors.yml` GitHub Action, which runs `tools/update-authors.mjs`.
           branch: actions/authors-update  # Custom branch *just* for this Action.
           commit-message: 'meta: update AUTHORS'
           labels: meta

.github/workflows/build-windows.yml

@@ -32,7 +32,7 @@ jobs:
     if: github.event.pull_request.draft == false
     strategy:
       matrix:
-        windows: [windows-2019, windows-2022]
+        windows: [windows-2019]
       fail-fast: false
     runs-on: ${{ matrix.windows }}
     steps:

.github/workflows/coverage-linux.yml

@@ -60,6 +60,6 @@ jobs:
       - name: Clean tmp
         run: rm -rf coverage/tmp && rm -rf out
       - name: Upload
-        uses: codecov/codecov-action@v1
+        uses: codecov/codecov-action@v3
         with:
           directory: ./coverage

.github/workflows/coverage-windows.yml

@@ -33,7 +33,7 @@ env:
 jobs:
   coverage-windows:
     if: github.event.pull_request.draft == false
-    runs-on: windows-latest
+    runs-on: windows-2019
     steps:
       - uses: actions/checkout@v3
         with:
@@ -61,6 +61,6 @@ jobs:
       - name: Clean tmp
         run: npx rimraf ./coverage/tmp
       - name: Upload
-        uses: codecov/codecov-action@v1
+        uses: codecov/codecov-action@v3
         with:
           directory: ./coverage

.github/workflows/find-inactive-collaborators.yml

@@ -30,7 +30,9 @@ jobs:
         run: tools/find-inactive-collaborators.mjs
 
       - name: Open pull request
-        uses: gr2m/create-or-update-pull-request-action@v1
+        uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        # Creates a PR or update the Action's existing PR, or
+        # no-op if the base branch is already up-to-date.
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:

.github/workflows/find-inactive-tsc.yml

@@ -39,7 +39,9 @@ jobs:
         run: tools/find-inactive-tsc.mjs >> $GITHUB_ENV
 
       - name: Open pull request
-        uses: gr2m/create-or-update-pull-request-action@v1
+        uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        # Creates a PR or update the Action's existing PR, or
+        # no-op if the base branch is already up-to-date.
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:

.github/workflows/license-builder.yml

@@ -15,7 +15,9 @@ jobs:
         with:
           persist-credentials: false
       - run: ./tools/license-builder.sh  # Run the license builder tool
-      - uses: gr2m/[email protected]  # Create a PR or update the Action's existing PR
+      - uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        # Creates a PR or update the Action's existing PR, or
+        # no-op if the base branch is already up-to-date.
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:

.github/workflows/linters.yml

@@ -49,6 +49,44 @@ jobs:
         run: npx envinfo
       - name: Lint C/C++ files
         run: make lint-cpp
+  format-cpp:
+    if: ${{ github.event.pull_request.draft == false && github.base_ref == 'master' }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+          persist-credentials: false
+      - name: Use Node.js ${{ env.NODE_VERSION }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v3
+        with:
+          python-version: ${{ env.PYTHON_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Format C/C++ files
+        run: |
+          make format-cpp-build
+          # The `make format-cpp` error code is intentionally ignored here
+          # because it is irrelevant. We already check if the formatter produced
+          # a diff in the next line.
+          # Refs: https://github.com/nodejs/node/pull/42764
+          CLANG_FORMAT_START="$(git merge-base HEAD refs/remotes/origin/$GITHUB_BASE_REF)" \
+            make format-cpp || true
+          git --no-pager diff --exit-code && EXIT_CODE="$?" || EXIT_CODE="$?"
+          if [ "$EXIT_CODE" != "0" ]
+          then
+            echo
+            echo 'ERROR: Please run:'
+            echo
+            echo "  CLANG_FORMAT_START="$\(git merge-base HEAD ${GITHUB_BASE_REF}\)" make format-cpp"
+            echo
+            echo 'to format the commits in your branch.'
+            exit "$EXIT_CODE"
+          fi
   lint-js-and-md:
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
@@ -118,15 +156,15 @@ jobs:
           persist-credentials: false
       - run: shellcheck -V
       - name: Lint Shell scripts
-        run: tools/lint-sh.js .
+        run: tools/lint-sh.mjs .
   lint-codeowners:
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
         with:
           persist-credentials: false
-      - uses: mszostok/codeowners-validator@v0.6.0
+      - uses: mszostok/codeowners-validator@7f3f5e28c6d7b8dfae5731e54ce2272ca384592f
         with:
           checks: files,duppatterns
   lint-pr-url:

.github/workflows/notify-force-push.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Slack Notification
-        uses: rtCamp/action-slack-notify@master
+        uses: rtCamp/action-slack-notify@12e36fc18b0689399306c2e0b3e0f2978b7f1ee7
         env:
           SLACK_COLOR: '#DE512A'
           SLACK_ICON: https://github.com/nodejs.png?size=48

.github/workflows/test-asan.yml

@@ -30,6 +30,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
+  ASAN_OPTIONS: intercept_tls_get_addr=0
   PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare
 

.github/workflows/tools.yml

@@ -80,7 +80,9 @@ jobs:
         with:
           persist-credentials: false
       - run: ${{ matrix.run }}
-      - uses: gr2m/create-or-update-pull-request-action@v1  # Create a PR or update the Action's existing PR
+      - uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        # Creates a PR or update the Action's existing PR, or
+        # no-op if the base branch is already up-to-date.
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:

.mailmap

@@ -50,6 +50,7 @@ Ashley Maceli <[email protected]>
 Ashok Suthar <[email protected]>
 Ashutosh Kumar Singh <[email protected]>
 Atsuo Fukaya <[email protected]>
+Austin Kelleher <[email protected]> <[email protected]>
 Azard <[email protected]> <[email protected]>
 Ben Lugavere <[email protected]>
 Ben Noordhuis <[email protected]> <[email protected]>
@@ -82,11 +83,14 @@ Brian White <[email protected]> <[email protected]>
 Caleb Boyd <[email protected]>
 Calvin Metcalf <[email protected]> <[email protected]>
 Calvin Metcalf <[email protected]> <[email protected]>
+Camillo Bruni <[email protected]> <[email protected]>
 Caralyn Reisle <[email protected]>
 Charles <[email protected]> <[email protected]>
 Charles Rudolph <[email protected]>
 Chen Gang <[email protected]>
 Chen Gang <[email protected]> <[email protected]>
+Chengzhong Wu <[email protected]>
+Chengzhong Wu <[email protected]> <[email protected]>
 Chew Choon Keat <[email protected]>
 Chris Andrews <[email protected]>
 Chris Johnson <[email protected]>
@@ -196,8 +200,6 @@ Hassaan Pasha <[email protected]> <[email protected]>
 Hendrik Schwalm <[email protected]>
 Henry Chin <[email protected]>
 Herbert Vojčík <[email protected]>
-himself65 <[email protected]> <[email protected]>
-himself65 <[email protected]> <[email protected]>
 Hitesh Kanwathirtha <[email protected]> <[email protected]>
 Icer Liang <[email protected]> <[email protected]>
 Igor Savin <[email protected]>
@@ -298,6 +300,7 @@ Lakshmi Swetha Gopireddy <[email protected]> <[email protected]
 Lars-Magnus Skog <[email protected]> <[email protected]>
 Lasse R.H. Nielsen <[email protected]>
 Leeseean Chiu <[email protected]>
+LiviaMedeiros <[email protected]> <[email protected]>
 Lucas Pardue <[email protected]> <[email protected]>
 Luke Bayes <[email protected]>
 Lydia Kats <[email protected]>
@@ -356,6 +359,8 @@ Mitar Milutinovic <[email protected]>
 Mithun Sasidharan <[email protected]> <[email protected]>
 Mohammed Keyvanzadeh <[email protected]>
 Mohammed Keyvanzadeh <[email protected]> <[email protected]>
+Morgan Roderick <[email protected]>
+Morgan Roderick <[email protected]> <[email protected]>
 MURAKAMI Masahiko <[email protected]> <[email protected]>
 Myles Borins <[email protected]> <[email protected]>
 Myles Borins <[email protected]> <[email protected]>
@@ -372,10 +377,17 @@ Nils Kuhnhenn <[email protected]>
 Nitzan Uziely <[email protected]> <[email protected]>
 Nitzan Uziely <[email protected]> <[email protected]>
 Noah Rose Ledesma <[email protected]>
+npm team <[email protected]>
+npm team <[email protected]> <npm CLI robot>
+npm team <[email protected]> <npm team>
+npm team <[email protected]> <[email protected]>
 Oliver Chang <[email protected]>
 Oluwaseun Omoyajowo <[email protected]>
+OneNail <[email protected]> <[email protected]>
 Onne Gorter <[email protected]>
 Oscar Martinez <[email protected]> <[email protected]>
+Paolo Insogna <[email protected]>
+Paolo Insogna <[email protected]> <[email protected]>
 Paul Graham <[email protected]> <[email protected]>
 Paul Querna <[email protected]> <[email protected]>
 Pedro Lima <[email protected]>
@@ -558,6 +570,8 @@ Yuta Hiroto <[email protected]>
 Zach Bjornson <[email protected]> <[email protected]>
 Zachary Scott <[email protected]> <[email protected]>
 Zachary Vacura <[email protected]>
+Zeyu "Alex" Yang <[email protected]> <[email protected]>
+Zeyu "Alex" Yang <[email protected]> <[email protected]>
 Zoran Tomicic <[email protected]>
 Сковорода Никита Андреевич <[email protected]>
 隋鑫磊 <[email protected]>

AUTHORS

@@ -2310,12 +2310,12 @@ Dzmitry_Prudnikau <[email protected]>
 Ian McKellar <[email protected]>
 Jennifer Bland <[email protected]>
 Kyle Fuller <[email protected]>
-Camillo Bruni <[email protected]>
+Camillo Bruni <[email protected]>
 Yongsheng Zhang <[email protected]>
 Neeraj Laad <[email protected]>
 Scott Van Gilder <[email protected]>
 Yaniv Friedensohn <[email protected]>
-Lucas Woo <[email protected]>
+Chengzhong Wu <[email protected]>
 Troels Liebe Bentsen <[email protected]>
 pranshuchittora <[email protected]>
 lakamsani <[email protected]>
@@ -2686,7 +2686,7 @@ Alexander Sattelmaier <[email protected]>
 Avi ד <[email protected]>
 Thomas <[email protected]>
 Aymen Naghmouchi <[email protected]>
-himself65 <[email protected]>
+Zeyu "Alex" Yang <[email protected]>
 Patrick Gansterer <[email protected]>
 Nicolas Moteau <[email protected]>
 Anthony Tuininga <[email protected]>
@@ -3260,7 +3260,6 @@ Siddharth <[email protected]>
 Cactysman <[email protected]>
 David Brownman <[email protected]>
 Michael Rommel <[email protected]>
-Chengzhong Wu <[email protected]>
 Andres <[email protected]>
 Jayden Seric <[email protected]>
 divlo <[email protected]>
@@ -3288,7 +3287,7 @@ pengjie <[email protected]>
 Philip <[email protected]>
 julianjany <[email protected]>
 bl-ue <[email protected]>
-npm-robot <[email protected]>
+npm team <[email protected]>
 Shaun Keys <[email protected]>
 Simone Busoli <[email protected]>
 Derevianchenko Maksym <[email protected]>
@@ -3430,9 +3429,8 @@ Derek Wolpert <[email protected]>
 wbt <[email protected]>
 Alexandru Comanescu <[email protected]>
 madflow <[email protected]>
-Austin Kelleher <austin.kell47@gmail.com>
+Austin Kelleher <austinlkelleher@gmail.com>
 apeltop <[email protected]>
-Livia Medeiros <[email protected]>
 Nikolaos Papaspyrou <[email protected]>
 Matt Probert <[email protected]>
 Roch Devost <[email protected]>
@@ -3452,5 +3450,23 @@ Daeyeon Jeong <[email protected]>
 Daniel Roe <[email protected]>
 Niyas Sait <[email protected]>
 K.C.Ashish Kumar <[email protected]>
+Niklas Mischkulnig <[email protected]>
+Liviu Ionescu <[email protected]>
+HE Shi-Jun <[email protected]>
+Yagiz Nizipli <[email protected]>
+liuxingbaoyu <[email protected]>
+Sergey Nazaryev <[email protected]>
+William Marlow <[email protected]>
+Keyhan Vakil <[email protected]>
+Feng Yu <[email protected]>
+pupilTong <[email protected]>
+rikapo <[email protected]>
+Meek Simbule <[email protected]>
+Michael Ficarra <[email protected]>
+hiroki osame <[email protected]>
+Eugene Chapko <[email protected]>
+Sergey Petushkov <[email protected]>
+Caleb Everett <[email protected]>
+JialuZhang-intel <[email protected]>
 
-# Generated by tools/update-authors.js
+# Generated by tools/update-authors.mjs