Skip to content

Commit 92e1aaa

Browse files
committed
net: Temporarily inc network_family_autoselection_attempt_timeout to 500ms
The timeout currently closes the connection instead of supporting parallel connections. This should be reset to 250ms if parallel connections are implemented as per RFC 8305.
1 parent 532fff6 commit 92e1aaa

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

doc/api/net.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1867,7 +1867,7 @@ added:
18671867
-->
18681868

18691869
Gets the current default value of the `autoSelectFamilyAttemptTimeout` option of [`socket.connect(options)`][].
1870-
The initial default value is `250` or the value specified via the command line
1870+
The initial default value is `500` or the value specified via the command line
18711871
option `--network-family-autoselection-attempt-timeout`.
18721872

18731873
* Returns: {number} The current default value of the `autoSelectFamilyAttemptTimeout` option.

src/node_options.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ class EnvironmentOptions : public Options {
151151
int64_t heap_snapshot_near_heap_limit = 0;
152152
std::string heap_snapshot_signal;
153153
bool network_family_autoselection = true;
154-
uint64_t network_family_autoselection_attempt_timeout = 250;
154+
uint64_t network_family_autoselection_attempt_timeout = 500;
155155
uint64_t max_http_header_size = 16 * 1024;
156156
bool deprecation = true;
157157
bool force_async_hooks_checks = true;

test/parallel/test-net-autoselectfamily-attempt-timeout-default-value.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ const { platformTimeout } = require('../common');
55
const assert = require('assert');
66
const { getDefaultAutoSelectFamilyAttemptTimeout } = require('net');
77

8-
assert.strictEqual(getDefaultAutoSelectFamilyAttemptTimeout(), platformTimeout(2500));
8+
assert.strictEqual(getDefaultAutoSelectFamilyAttemptTimeout(), platformTimeout(5000));

0 commit comments

Comments
 (0)