Skip to content

Commit 96f1052

Browse files
TrottBethGriggs
authored andcommitted
test: add tests for missing https agent options
Add test that minVersion and maxVersion options are accepted. This should complete coverage for lib/https.js. Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js PR-URL: #38202 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 9d8d9c3 commit 96f1052

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

test/parallel/test-https-agent-additional-options.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ const updatedValues = new Map([
3636
['dhparam', fixtures.readKey('dh2048.pem')],
3737
['ecdhCurve', 'secp384r1'],
3838
['honorCipherOrder', true],
39+
['minVersion', 'TLSv1.1'],
40+
['maxVersion', 'TLSv1.3'],
3941
['secureOptions', crypto.constants.SSL_OP_CIPHER_SERVER_PREFERENCE],
4042
['secureProtocol', 'TLSv1_1_method'],
4143
['sessionIdContext', 'sessionIdContext'],

0 commit comments

Comments
 (0)