Skip to content

Commit 9804e7f

Browse files
ofrobotsMylesBorins
authored andcommitted
deps: V8: cherry-pick 9622696 from upstream
Original commit message: [profiler] sampled allocations should be marked as independent Sampling heap profiler keeps weak references. These should be marked independent so that the weak callback can be dispatched on new space collections. BUG= v8:4959 LOG=N [email protected] Review-Url: https://codereview.chromium.org/1945193002 Cr-Commit-Position: refs/heads/master@{#36012} Ref: https://bugs.chromium.org/p/v8/issues/detail?id=4959 Ref: v8/v8@9622696
1 parent 93ca2f7 commit 9804e7f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

deps/v8/include/v8-version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 5
1212
#define V8_MINOR_VERSION 1
1313
#define V8_BUILD_NUMBER 281
14-
#define V8_PATCH_LEVEL 109
14+
#define V8_PATCH_LEVEL 110
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

deps/v8/src/profiler/sampling-heap-profiler.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ void SamplingHeapProfiler::SampleObject(Address soon_object, size_t size) {
109109
Sample* sample = new Sample(size, node, loc, this);
110110
samples_.insert(sample);
111111
sample->global.SetWeak(sample, OnWeakCallback, WeakCallbackType::kParameter);
112+
sample->global.MarkIndependent();
112113
}
113114

114115
void SamplingHeapProfiler::OnWeakCallback(

0 commit comments

Comments
 (0)