Skip to content

Commit a4a4819

Browse files
TrottMylesBorins
authored andcommitted
test: do not check text for engine-generated error
In test-tls-wrap-event-emitter, the text of a TypeError is checked as part of the test. However, this text is generated by the JavaScript engine (V8) and not Node.js. Thus, we should not check the text as JS engine error messages can change without it being considered a breaking change for Node.js. A side effect is that node-chakracore will no longer need to patch this test to pass. PR-URL: #19215 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 9613e02 commit a4a4819

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/parallel/test-tls-wrap-event-emmiter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ const TlsSocket = require('tls').TLSSocket;
1515
const EventEmitter = require('events').EventEmitter;
1616
assert.throws(
1717
() => { new TlsSocket(new EventEmitter()); },
18-
/^TypeError: (.+) is not a function$/
18+
TypeError
1919
);

0 commit comments

Comments
 (0)