Skip to content

Commit ae3185b

Browse files
mhdawsonMyles Borins
authored and
Myles Borins
committed
test: disable fs watch tests for AIX
fs watch currently needs special configuration on AIX and we want to improve under #5085. Tests are disabled so CI can be green and we can spot other regressions until this work is complete. test-async-wrap-check-providers does not aim to test fs watch but part of the test uses it so that part has been skipped for AIX PR-URL: #5187 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent b2e72c0 commit ae3185b

File tree

3 files changed

+32
-3
lines changed

3 files changed

+32
-3
lines changed

test/parallel/parallel.status

+7
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,10 @@ test-tick-processor : PASS,FLAKY
2020
test-debug-signal-cluster : PASS,FLAKY
2121

2222
[$system==freebsd]
23+
24+
# fs-watch currently needs special configuration on AIX and we
25+
# want to improve under https://github.com/nodejs/node/issues/5085.
26+
# Tests are disabled so CI can be green and we can spot other
27+
# regressions until this work is complete
28+
[$system==aix]
29+
test-fs-watch-enoent : FAIL, PASS

test/parallel/test-async-wrap-check-providers.js

+19-3
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,16 @@ let keyList = pkeys.slice();
1818
// Drop NONE
1919
keyList.splice(0, 1);
2020

21+
// fs-watch currently needs special configuration on AIX and we
22+
// want to improve under https://github.com/nodejs/node/issues/5085.
23+
// strip out fs watch related parts for now
24+
if (common.isAix) {
25+
for (var i = 0; i < keyList.length; i++) {
26+
if ((keyList[i] === 'FSEVENTWRAP') || (keyList[i] === 'STATWATCHER')) {
27+
keyList.splice(i, 1);
28+
}
29+
}
30+
}
2131

2232
function init(id) {
2333
keyList = keyList.filter((e) => e != pkeys[id]);
@@ -33,9 +43,15 @@ async_wrap.enable();
3343
setTimeout(function() { });
3444

3545
fs.stat(__filename, noop);
36-
fs.watchFile(__filename, noop);
37-
fs.unwatchFile(__filename);
38-
fs.watch(__filename).close();
46+
47+
if (!common.isAix) {
48+
// fs-watch currently needs special configuration on AIX and we
49+
// want to improve under https://github.com/nodejs/node/issues/5085.
50+
// strip out fs watch related parts for now
51+
fs.watchFile(__filename, noop);
52+
fs.unwatchFile(__filename);
53+
fs.watch(__filename).close();
54+
}
3955

4056
dns.lookup('localhost', noop);
4157
dns.lookupService('::', 0, noop);

test/sequential/sequential.status

+6
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,9 @@ test-vm-syntax-error-stderr : PASS,FLAKY
1717

1818
[$system==freebsd]
1919

20+
# fs-watch currently needs special configuration on AIX and we
21+
# want to improve under https://github.com/nodejs/node/issues/5085.
22+
# Tests are disabled so CI can be green and we can spot other
23+
# regressions until this work is complete
24+
[$system==aix]
25+
test-fs-watch : FAIL, PASS

0 commit comments

Comments
 (0)