Skip to content

Commit b43866c

Browse files
refackjasnell
authored andcommitted
tools: include exit code in TAP log
PR-URL: #19855 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
1 parent 114ba67 commit b43866c

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

tools/test.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -254,11 +254,12 @@ def HasRun(self, output):
254254

255255
class TapProgressIndicator(SimpleProgressIndicator):
256256

257-
def _printDiagnostic(self, traceback, severity):
258-
logger.info(' severity: %s', severity)
257+
def _printDiagnostic(self):
258+
logger.info(' severity: %s', self.severity)
259+
self.exitcode and logger.info(' exitcode: %s', self.exitcode)
259260
logger.info(' stack: |-')
260261

261-
for l in traceback.splitlines():
262+
for l in self.traceback.splitlines():
262263
logger.info(' ' + l)
263264

264265
def Starting(self):
@@ -273,6 +274,7 @@ def HasRun(self, output):
273274
self._done += 1
274275
self.traceback = ''
275276
self.severity = 'ok'
277+
self.exitcode = ''
276278

277279
# Print test name as (for example) "parallel/test-assert". Tests that are
278280
# scraped from the addons documentation are all named test.js, making it
@@ -284,7 +286,8 @@ def HasRun(self, output):
284286
if output.UnexpectedOutput():
285287
status_line = 'not ok %i %s' % (self._done, command)
286288
self.severity = 'fail'
287-
self.traceback = "exit code: " + output.output.exit_code + "\n" + output.output.stdout + output.output.stderr
289+
self.exitcode = output.output.exit_code
290+
self.traceback = output.output.stdout + output.output.stderr
288291

289292
if FLAKY in output.test.outcomes and self.flaky_tests_mode == DONTCARE:
290293
status_line = status_line + ' # TODO : Fix flaky test'
@@ -330,7 +333,7 @@ def HasRun(self, output):
330333
if self.severity is not 'ok' or self.traceback is not '':
331334
if output.HasTimedOut():
332335
self.traceback = 'timeout'
333-
self._printDiagnostic(self.traceback, self.severity)
336+
self._printDiagnostic()
334337
logger.info(' ...')
335338

336339
def Done(self):

0 commit comments

Comments
 (0)