Skip to content

Commit cdd1c66

Browse files
joyeecheungruyadorno
authored andcommitted
deps: V8: cherry-pick b33bf2dfd261
Original commit message: Ignore --predictable when computing flag list hashes This allows reproducible code cache generation. Refs: #48749 Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766 Reviewed-by: Leszek Swirski <[email protected]> Commit-Queue: Joyee Cheung <[email protected]> Cr-Commit-Position: refs/heads/main@{#88943} Refs: v8/v8@b33bf2d PR-URL: #49703 Refs: v8/v8@de9a5de Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent 5ad0042 commit cdd1c66

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

deps/v8/src/flags/flags.cc

+3-1
Original file line numberDiff line numberDiff line change
@@ -539,8 +539,10 @@ uint32_t ComputeFlagListHash() {
539539
// We want to be able to flip --profile-deserialization without
540540
// causing the code cache to get invalidated by this hash.
541541
if (flag.PointsTo(&v8_flags.profile_deserialization)) continue;
542-
// Skip v8_flags.random_seed to allow predictable code caching.
542+
// Skip v8_flags.random_seed and v8_flags.predictable to allow predictable
543+
// code caching.
543544
if (flag.PointsTo(&v8_flags.random_seed)) continue;
545+
if (flag.PointsTo(&v8_flags.predictable)) continue;
544546
modified_args_as_string << flag;
545547
}
546548
std::string args(modified_args_as_string.str());

0 commit comments

Comments
 (0)