Skip to content

Commit d6e9446

Browse files
yashLadhaTrott
authored andcommitted
src: add context for TODO comment in env.cc
Add more context around the TODO change required for achieving the task. When destructuring the isolate and environment_vars from the environment object, it is leading to recursive dependency and thus not able to refactor it in a better way. PR-URL: #37140 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 36cc0ee commit d6e9446

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/env.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,8 @@ Environment::Environment(IsolateData* isolate_data,
368368

369369
set_env_vars(per_process::system_environment);
370370
// TODO(joyeecheung): pass Isolate* and env_vars to it instead of the entire
371-
// env
371+
// env, when the recursive dependency inclusion in "debug-utils.h" is
372+
// resolved.
372373
enabled_debug_list_.Parse(this);
373374

374375
// We create new copies of the per-Environment option sets, so that it is

0 commit comments

Comments
 (0)