Skip to content

Commit ea20796

Browse files
bnoordhuisMyles Borins
authored and
Myles Borins
committed
build,test: fix build-addons dependency chain
* Make the 'extract embedded addons in the documentations' step a normal prerequisite. As an order-only prerequisite, it's sometimes skipped when it shouldn't be. * Make `tools/doc/addon-verify.js` a dependency of that step. Changes to that file should result in a rebuild. PR-URL: #6652 Reviewed-By: Anna Henningsen <[email protected]>
1 parent b869cdb commit ea20796

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Makefile

+3-3
Original file line numberDiff line numberDiff line change
@@ -128,17 +128,17 @@ test/gc/node_modules/weak/build/Release/weakref.node: $(NODE_EXE)
128128
--nodedir="$(shell pwd)"
129129

130130
# Implicitly depends on $(NODE_EXE), see the build-addons rule for rationale.
131-
test/addons/.docbuildstamp: doc/api/addons.md
131+
test/addons/.docbuildstamp: tools/doc/addon-verify.js doc/api/addons.md
132132
$(RM) -r test/addons/??_*/
133-
$(NODE) tools/doc/addon-verify.js
133+
$(NODE) $<
134134
touch $@
135135

136136
ADDONS_BINDING_GYPS := \
137137
$(filter-out test/addons/??_*/binding.gyp, \
138138
$(wildcard test/addons/*/binding.gyp))
139139

140140
# Implicitly depends on $(NODE_EXE), see the build-addons rule for rationale.
141-
test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) | test/addons/.docbuildstamp
141+
test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) test/addons/.docbuildstamp
142142
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
143143
# embedded addons have been generated from the documentation.
144144
for dirname in test/addons/*/; do \

0 commit comments

Comments
 (0)