Skip to content

Commit f265225

Browse files
tomgcoaddaleax
authored andcommitted
src: allow --perf-prof-unwinding-info in NODE_OPTIONS
PR-URL: #25565 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent f5b9a78 commit f265225

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

doc/api/cli.md

+1
Original file line numberDiff line numberDiff line change
@@ -730,6 +730,7 @@ V8 options that are allowed are:
730730
- `--perf-basic-prof`
731731
- `--perf-basic-prof-only-functions`
732732
- `--perf-prof`
733+
- `--perf-prof-unwinding-info`
733734
- `--stack-trace-limit`
734735

735736
### `NODE_PATH=path[:…]`

src/node_options.cc

+4
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,10 @@ PerIsolateOptionsParser::PerIsolateOptionsParser() {
322322
V8Option{},
323323
kAllowedInEnvironment);
324324
AddOption("--perf-prof", "", V8Option{}, kAllowedInEnvironment);
325+
AddOption("--perf-prof-unwinding-info",
326+
"",
327+
V8Option{},
328+
kAllowedInEnvironment);
325329
AddOption("--stack-trace-limit", "", V8Option{}, kAllowedInEnvironment);
326330

327331
#ifdef NODE_REPORT

test/parallel/test-cli-node-options.js

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ if (!common.isWindows) {
4444
if (common.isLinux && ['arm', 'x64'].includes(process.arch)) {
4545
// PerfJitLogger is only implemented in Linux.
4646
expect('--perf-prof', 'B\n');
47+
expect('--perf-prof-unwinding-info', 'B\n');
4748
}
4849

4950
if (common.hasCrypto) {

0 commit comments

Comments
 (0)