Skip to content

Commit f98687d

Browse files
committed
doc,test: minor improvements to O_DSYNC
PR-URL: #15547 Refs: #15451 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 3a69ef5 commit f98687d

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

doc/api/fs.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -2806,12 +2806,13 @@ The following constants are meant for use with `fs.open()`.
28062806
</tr>
28072807
<tr>
28082808
<td><code>O_SYNC</code></td>
2809-
<td>Flag indicating that the file is opened for synchronous I/O.</td>
2809+
<td>Flag indicating that the file is opened for synchronized I/O with write
2810+
operations waiting for file integrity.</td>
28102811
</tr>
28112812
<tr>
28122813
<td><code>O_DSYNC</code></td>
2813-
<td>Flag indicating that the file is opened for synchronous I/O
2814-
with write operations waiting for data integrity.</td>
2814+
<td>Flag indicating that the file is opened for synchronized I/O with write
2815+
operations waiting for data integrity.</td>
28152816
</tr>
28162817
<tr>
28172818
<td><code>O_SYMLINK</code></td>

test/parallel/test-fs-open-flags.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,8 @@ common.expectsError(
8181
{ code: 'ERR_INVALID_OPT_VALUE', type: TypeError }
8282
);
8383

84-
if (common.isLinux === true) {
84+
if (common.isLinux) {
8585
const file = fixtures.path('a.js');
8686

87-
fs.open(file, O_DSYNC, common.mustCall(function(err, fd) {
88-
assert.ifError(err);
89-
}));
87+
fs.open(file, O_DSYNC, common.mustCall(assert.ifError));
9088
}

0 commit comments

Comments
 (0)