quic: cleanup QuicSession code

- Do not create new `v8::Function` objects, both for performance
  and because it is unclear whether that leaks memory
  (Node.js issue 28988).
- Do not put functions into the inline header that do not need to
  be there or that do not make sense as inline functions
  (in particular, callbacks that are provided to C libraries can
  not be realized as inline functions by the compiler).
- Remove implicit/redundant `inline` qualifiers and add appropriate
  `const` qualifiers.
- Remove unnecessary `this->` prefixes.
- Return early for JS failures rather than accumulating them.
- Minor stylistic changes.

PR-URL: #126
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: addaleax

lib/internal/quic/core.js

@@ -262,8 +262,7 @@ function onSessionClose(code, family) {
 // some basic information about the ALPN, SNI, and Ciphers that are
 // being requested. It is only called if the 'clientHello' event is
 // listened for.
-function onSessionClientHello(alpn, servername, ciphers, callback) {
-  callback = callback.bind(this);
+function onSessionClientHello(alpn, servername, ciphers) {
   this[owner_symbol][kClientHello](
     alpn,
     servername,
@@ -274,7 +273,7 @@ function onSessionClientHello(alpn, servername, ciphers, callback) {
         return;
       }
       try {
-        callback(...args);
+        this.onClientHelloDone(...args);
       } catch (err) {
         this[owner_symbol].destroy(err);
       }
@@ -283,10 +282,9 @@ function onSessionClientHello(alpn, servername, ciphers, callback) {
 
 // This callback is only ever invoked for QuicServerSession instances,
 // and is used to trigger OCSP request processing when needed. The
-// user callback must invoke the callback function in order for the
+// user callback must invoke .onCertDone() in order for the
 // TLS handshake to continue.
-function onSessionCert(servername, callback) {
-  callback = callback.bind(this);
+function onSessionCert(servername) {
   this[owner_symbol][kCert](servername, (err, context, ocspResponse) => {
     if (err) {
       this[owner_symbol].destroy(err);
@@ -311,7 +309,7 @@ function onSessionCert(servername, callback) {
       }
     }
     try {
-      callback(context ? context.context : undefined, ocspResponse);
+      this.onCertDone(context ? context.context : undefined, ocspResponse);
     } catch (err) {
       this[owner_symbol].destroy(err);
     }