Skip to content

Commit 9173f86

Browse files
authored
Replace outdated comment in Windows Terminal overlay class selection (#14048)
microsoft/terminal#12358 Summary of the issue: A comment in NVDAObjects.UIA.FindOverlayClasses does not reflect reality. Description of how this pull request fixes the issue: Comment replaced with a more accurate one.
1 parent 7a95ccd commit 9173f86

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

source/NVDAObjects/UIA/__init__.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -1187,11 +1187,12 @@ def findOverlayClasses(self,clsList):
11871187
from . import winConsoleUIA
11881188
winConsoleUIA.findExtraOverlayClasses(self, clsList)
11891189
elif UIAClassName in ("TermControl", "TermControl2"):
1190-
# microsoft/terminal#12358: Eventually, TermControl2 should have
1191-
# a separate overlay class that is not a descendant of LiveText.
1192-
# TermControl2 sends inserted text using UIA notification events,
1193-
# so it is no longer necessary to diff the object as with all
1194-
# previous terminal implementations.
1190+
# TermControl2 was going to represent a terminal that supported UIA
1191+
# notifications (i.e. one where microsoft/terminal#12358 has been
1192+
# merged). However, the UIA class name was not changed in
1193+
# microsoft/terminal#12358 due to backward compat concerns raised
1194+
# by Freedom Scientific. However, a check for it is kept here just
1195+
# in case it should later become necessary to change it.
11951196
from . import winConsoleUIA
11961197
clsList.append(winConsoleUIA.WinTerminalUIA)
11971198

0 commit comments

Comments
 (0)