Add close to credential storage (#5283)

* Add close method to credential storage

* wip

Author: octol

common/credential-storage/src/backends/sqlite.rs

@@ -23,6 +23,11 @@ impl SqliteEcashTicketbookManager {
         SqliteEcashTicketbookManager { connection_pool }
     }
 
+    /// Closes the connection pool.
+    pub async fn close(&self) {
+        self.connection_pool.close().await
+    }
+
     pub(crate) async fn cleanup_expired(&self, deadline: Date) -> Result<(), sqlx::Error> {
         sqlx::query!(
             "DELETE FROM ecash_ticketbook WHERE expiration_date <= ?",

common/credential-storage/src/ephemeral_storage.rs

@@ -43,6 +43,10 @@ impl Debug for EphemeralStorage {
 impl Storage for EphemeralStorage {
     type StorageError = StorageError;
 
+    async fn close(&self) {
+        // nothing to do here
+    }
+
     async fn cleanup_expired(&self) -> Result<(), Self::StorageError> {
         self.storage_manager.cleanup_expired().await;
         Ok(())

common/credential-storage/src/persistent_storage/mod.rs

@@ -89,6 +89,10 @@ impl PersistentStorage {
 impl Storage for PersistentStorage {
     type StorageError = StorageError;
 
+    async fn close(&self) {
+        self.storage_manager.close().await
+    }
+
     /// remove all expired ticketbooks and expiration date signatures
     async fn cleanup_expired(&self) -> Result<(), Self::StorageError> {
         let ecash_yesterday = ecash_today().date().previous_day().unwrap();

common/credential-storage/src/storage.rs

@@ -22,6 +22,8 @@ use std::error::Error;
 pub trait Storage: Send + Sync {
     type StorageError: Error;
 
+    async fn close(&self);
+
     /// remove all expired ticketbooks and expiration date signatures
     async fn cleanup_expired(&self) -> Result<(), Self::StorageError>;