Skip to content

Decouple ROFL event notifier and sub-handler #6014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peternose opened this issue Jan 28, 2025 · 1 comment
Open

Decouple ROFL event notifier and sub-handler #6014

peternose opened this issue Jan 28, 2025 · 1 comment
Assignees

Comments

@peternose
Copy link
Contributor

The ROFL event notifier should be decoupled from the ROFL sub-handler to ensure that these structures are independent of each other. Additionally, the ROFL event notifier should terminate when the ROFL component is stopped (e.g., during an upgrade) to prevent resource leaks.

Ideally, every RONL component should have a handler and a notifier, and every ROFL component should have a sub-handler and a sub-notifier.

@kostko
Copy link
Member

kostko commented Apr 24, 2025

This is also causing problems with notifications not being delivered to components in case there are multiple components and some are not working. The reason is sequential call propagation with a shared context. When we have sub-notifiers, this somewhat hacky call propagation can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants