Skip to content

Testing: Lively Classic 1.0 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
allanaaa opened this issue Apr 7, 2025 · 3 comments
Open

Testing: Lively Classic 1.0 #2

allanaaa opened this issue Apr 7, 2025 · 3 comments

Comments

@allanaaa
Copy link

allanaaa commented Apr 7, 2025

Results from testing this new theme.

@nelsonamaya82 @aviannamiller

@allanaaa
Copy link
Author

allanaaa commented Apr 7, 2025

Things look really good so far!

  1. On the homepage, the featured records come in plain rectangles, unlike the rest of the theme design. Is that deliberate? I would rather have the usual border radiuses and dashes. I do like the contrast background - wonder if we could tie each record to a separate colour choice.
Image
  1. I'm getting some odd button size growth when moused over - only on the active selection:
Screen.Recording.2025-04-07.at.17.23.24.mov

@aviannamiller
Copy link

aviannamiller commented Apr 8, 2025

  1. The nav menu is truncating list items when there are more than ~9:
    Screenshot of nav bar with more than nine list items on a page with Lively applied. On the right, there is a cut off list item When this overflow of list items occurs, the nav container increases in height, which creates a bit of a cumbersome scrolling experience for viewing main page content.
  2. The menu drawer produces a scrollable list where all list items are accessible, however there are a11y issues with the menu drawer toggle (for both open and close) and obscured focus when tabbing. These same issues have also been described for Lively on S (omeka-s-themes/lively#17 and omeka-s-themes/lively#18).
  3. The skipnav link is not currently functional. It is linking out to an incorrect ID and should be corrected to href="#main-content".
  4. All record tag colors are failing minimum contrast requirements (against #F3F3F3 background). Minimum contrast for UI components is 3:1. Consider creating higher contrast by darkening record tag colors and/or lightening tag backgrounds, or make color (with appropriate contrast against page/container background) fill the entire tag (similar to Freedom).
  5. There are a number of semantic issues. The site-title should be coded as <h1>. Page titles would then be <h2> (they are currently tagged as <h1>, except for headings on the main landing page, which are correctly tagged). Resource headings are then also tagged as <h2> but should be <h3> in order to achieve logical semantic ordering. The footer then jumps all the way to <h6>. Skipping heading levels is discouraged, and the footer heading would be more accurately described as <h2>.
  6. ul elements (used for Featured Content) have direct children (div) that are not allowed on these elements.
  7. #menu-backer element on menu drawer is missing accessible text.
  8. There are unnecessary type attributes on JS resources and the style element.

@allanaaa
Copy link
Author

allanaaa commented May 2, 2025

  1. On item view pages, you call the medium (non-square, regular-ratio) thumbnail in the Files list, but constrain it to a square, which distorts it:
    https://dev.omeka.org/amayer/amayer-c/omeka/items/show/6442
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants