internal: test, receive pack only send packfile if there are non-delete commands

Author: aymanbagabas

internal/transport/test/receive_pack.go

@@ -274,11 +274,21 @@ func (s *ReceivePackSuite) receivePackNoCheck(ep *transport.Endpoint,
 		s.Require().NotNil(info, comment)
 	}
 
-	if fixture != nil {
-		s.Require().NotNil(fixture.Packfile())
-		req.Packfile = fixture.Packfile()
-	} else {
-		req.Packfile = s.emptyPackfile()
+	var needPackfile bool
+	for _, cmd := range req.Commands {
+		if cmd.Action() != packp.Delete {
+			needPackfile = true
+			break
+		}
+	}
+
+	if needPackfile {
+		if fixture != nil {
+			s.Require().NotNil(fixture.Packfile())
+			req.Packfile = fixture.Packfile()
+		} else {
+			req.Packfile = s.emptyPackfile()
+		}
 	}
 
 	return conn.Push(ctx, req)
@@ -370,9 +380,6 @@ func (s *ReceivePackSuite) testSendPackAddReference() {
 			{Name: "refs/heads/newbranch", Old: plumbing.ZeroHash, New: plumbing.NewHash(fixture.Head)},
 		},
 	}
-	// if refs.Capabilities.Supports(capability.ReportStatus) {
-	// 	req.Capabilities.Set(capability.ReportStatus)
-	// }
 
 	s.receivePack(s.Endpoint, req, fixture, false)
 	s.checkRemoteReference(s.Endpoint, "refs/heads/newbranch", plumbing.NewHash(fixture.Head))
@@ -400,9 +407,6 @@ func (s *ReceivePackSuite) testSendPackDeleteReference() {
 			{Name: "refs/heads/newbranch", Old: plumbing.NewHash(fixture.Head), New: plumbing.ZeroHash},
 		},
 	}
-	// if refs.Capabilities.Supports(capability.ReportStatus) {
-	// 	req.Capabilities.Set(capability.ReportStatus)
-	// }
 
 	if !caps.Supports(capability.DeleteRefs) {
 		s.Fail("capability delete-refs not supported")