plumbing: transport, correct tests for update-requests capabilities and

add missing packfile in tests

Author: aymanbagabas

internal/transport/test/receive_pack.go

@@ -211,9 +211,6 @@ func (s *ReceivePackSuite) TestSendPackOnNonEmptyWithReportStatusWithError() {
 	req.Commands = []*packp.Command{
 		{Name: "refs/heads/master", Old: plumbing.ZeroHash, New: plumbing.NewHash(fixture.Head)},
 	}
-	// req.Capabilities.Set(capability.ReportStatus)
-
-	// report, err := s.receivePackNoCheck(endpoint, req, fixture, full)
 	err := s.receivePackNoCheck(endpoint, req, fixture, full)
 	// XXX: Recent git versions return "failed to update ref", while older
 	//     (>=1.9) return "failed to lock".

plumbing/transport/build_update_requests_test.go

@@ -75,8 +75,8 @@ func TestBuildUpdateRequestsWithProgress(t *testing.T) {
 
 	upreq := buildUpdateRequests(caps, req)
 
-	// Verify Sideband64k capability is set
-	assert.True(t, upreq.Capabilities.Supports(capability.Sideband64k))
+	// Verify Sideband64k capability is not set
+	assert.False(t, upreq.Capabilities.Supports(capability.Sideband64k))
 	assert.False(t, upreq.Capabilities.Supports(capability.Sideband))
 	assert.False(t, upreq.Capabilities.Supports(capability.NoProgress))
 }
@@ -99,9 +99,9 @@ func TestBuildUpdateRequestsWithProgressFallback(t *testing.T) {
 
 	upreq := buildUpdateRequests(caps, req)
 
-	// Verify Sideband capability is set but not Sideband64k
+	// Verify Sideband capability is not set but not Sideband64k
 	assert.False(t, upreq.Capabilities.Supports(capability.Sideband64k))
-	assert.True(t, upreq.Capabilities.Supports(capability.Sideband))
+	assert.False(t, upreq.Capabilities.Supports(capability.Sideband))
 	assert.False(t, upreq.Capabilities.Supports(capability.NoProgress))
 }
 
@@ -122,8 +122,8 @@ func TestBuildUpdateRequestsWithNoProgress(t *testing.T) {
 
 	upreq := buildUpdateRequests(caps, req)
 
-	// Verify NoProgress capability is set
-	assert.True(t, upreq.Capabilities.Supports(capability.NoProgress))
+	// Verify NoProgress capability is not set
+	assert.False(t, upreq.Capabilities.Supports(capability.NoProgress))
 }
 
 func TestBuildUpdateRequestsWithAtomic(t *testing.T) {
@@ -184,12 +184,8 @@ func TestBuildUpdateRequestsWithAgent(t *testing.T) {
 
 	upreq := buildUpdateRequests(caps, req)
 
-	// Verify Agent capability is set
-	assert.True(t, upreq.Capabilities.Supports(capability.Agent))
-
-	// Verify agent value is set to default agent
-	val := upreq.Capabilities.Get(capability.Agent)
-	assert.Equal(t, []string{capability.DefaultAgent()}, val)
+	// Verify Agent capability is not set
+	assert.False(t, upreq.Capabilities.Supports(capability.Agent))
 }
 
 // mockWriter is a simple io.Writer implementation for testing

plumbing/transport/send_pack_test.go

@@ -89,7 +89,7 @@ func (rw *mockReadWriteCloser) Close() error {
 // TestSendPackWithReportStatus tests the SendPack function with ReportStatus capability
 func TestSendPackWithReportStatus(t *testing.T) {
 	caps := capability.NewList()
-	caps.Add(capability.ReportStatus)
+	caps.Add(capability.ReportStatus) //nolint:errcheck
 	conn := &mockConnection{caps: caps}
 
 	// Create a mock reader with a valid report status response
@@ -101,6 +101,7 @@ func TestSendPackWithReportStatus(t *testing.T) {
 	reader := newMockRWC([]byte(reportStatusResponse))
 	writer := newMockRWC(nil)
 
+	var buf bytes.Buffer
 	req := &PushRequest{
 		Commands: []*packp.Command{
 			{
@@ -109,6 +110,7 @@ func TestSendPackWithReportStatus(t *testing.T) {
 				New:  plumbing.NewHash("0123456789012345678901234567890123456789"),
 			},
 		},
+		Packfile: io.NopCloser(&buf), // Use a buffer to simulate packfile
 	}
 
 	storer := memory.NewStorage()
@@ -135,6 +137,7 @@ func TestSendPackWithReportStatusError(t *testing.T) {
 	reader := newMockRWC([]byte(reportStatusResponse))
 	writer := newMockRWC(nil)
 
+	var buf bytes.Buffer
 	req := &PushRequest{
 		Commands: []*packp.Command{
 			{
@@ -143,6 +146,7 @@ func TestSendPackWithReportStatusError(t *testing.T) {
 				New:  plumbing.NewHash("0123456789012345678901234567890123456789"),
 			},
 		},
+		Packfile: io.NopCloser(&buf), // Use a buffer to simulate packfile
 	}
 
 	// Call SendPack
@@ -167,6 +171,7 @@ func TestSendPackWithoutReportStatus(t *testing.T) {
 	reader := newMockRWC(nil)
 	writer := newMockRWC(nil)
 
+	var buf bytes.Buffer
 	req := &PushRequest{
 		Commands: []*packp.Command{
 			{
@@ -175,6 +180,7 @@ func TestSendPackWithoutReportStatus(t *testing.T) {
 				New:  plumbing.NewHash("0123456789012345678901234567890123456789"),
 			},
 		},
+		Packfile: io.NopCloser(&buf), // Use a buffer to simulate packfile
 	}
 
 	storer := memory.NewStorage()
@@ -216,6 +222,7 @@ func TestSendPackWithProgress(t *testing.T) {
 	// Create a progress buffer to capture progress messages
 	progressBuf := &bytes.Buffer{}
 
+	var buf bytes.Buffer
 	req := &PushRequest{
 		Commands: []*packp.Command{
 			{
@@ -224,6 +231,7 @@ func TestSendPackWithProgress(t *testing.T) {
 				New:  plumbing.NewHash("0123456789012345678901234567890123456789"),
 			},
 		},
+		Packfile: io.NopCloser(&buf), // Use a buffer to simulate packfile
 		Progress: progressBuf,
 	}
 
@@ -289,6 +297,7 @@ func TestSendPackErrors(t *testing.T) {
 		writer.writeErr = errors.New("encode error")
 		reader := newMockRWC(nil)
 
+		var buf bytes.Buffer
 		req := &PushRequest{
 			Commands: []*packp.Command{
 				{
@@ -297,6 +306,7 @@ func TestSendPackErrors(t *testing.T) {
 					New:  plumbing.NewHash("0123456789012345678901234567890123456789"),
 				},
 			},
+			Packfile: io.NopCloser(&buf), // Use a buffer to simulate packfile
 		}
 
 		storer := memory.NewStorage()
@@ -336,6 +346,7 @@ func TestSendPackErrors(t *testing.T) {
 		writer.closeErr = errors.New("writer close error")
 		reader := newMockRWC(nil)
 
+		var buf bytes.Buffer
 		req := &PushRequest{
 			Commands: []*packp.Command{
 				{
@@ -344,6 +355,7 @@ func TestSendPackErrors(t *testing.T) {
 					New:  plumbing.NewHash("0123456789012345678901234567890123456789"),
 				},
 			},
+			Packfile: io.NopCloser(&buf), // Use a buffer to simulate packfile
 		}
 
 		storer := memory.NewStorage()
@@ -361,6 +373,7 @@ func TestSendPackErrors(t *testing.T) {
 		reader := newMockRWC([]byte(invalidResponse))
 		writer := newMockRWC(nil)
 
+		var buf bytes.Buffer
 		req := &PushRequest{
 			Commands: []*packp.Command{
 				{
@@ -369,6 +382,7 @@ func TestSendPackErrors(t *testing.T) {
 					New:  plumbing.NewHash("0123456789012345678901234567890123456789"),
 				},
 			},
+			Packfile: io.NopCloser(&buf), // Use a buffer to simulate packfile
 		}
 
 		storer := memory.NewStorage()
@@ -388,6 +402,7 @@ func TestSendPackErrors(t *testing.T) {
 		reader.closeErr = errors.New("reader close error")
 		writer := newMockRWC(nil)
 
+		var buf bytes.Buffer
 		req := &PushRequest{
 			Commands: []*packp.Command{
 				{
@@ -396,6 +411,7 @@ func TestSendPackErrors(t *testing.T) {
 					New:  plumbing.NewHash("0123456789012345678901234567890123456789"),
 				},
 			},
+			Packfile: io.NopCloser(&buf), // Use a buffer to simulate packfile
 		}
 
 		storer := memory.NewStorage()