-
-
Notifications
You must be signed in to change notification settings - Fork 668
Feature Request: Add a subcommand to list all skipped/pending tests #1537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Just opened a PR with the code linked |
hey there - my first question was gonna be "how could In any event - my first instinct was to say "you shouldn't need static analysis for this - go's toolchain is plenty fast and --dry-run adds very little overhead" but playing with your repo has convinced me otherwise. the PR you've shared is a good start. it'll need some integration tests and documentation, and i'd prefer we go with something like if possible it would be great to support the case where a user is passing the So:
thoughts? |
Hi Ginkgo team! 👋
Our team at Kuma service mesh would love to have an easy way to list all pending or skipped test specs. Here's why:
We run many end-to-end (e2e) tests, and occasionally, some tests become flaky. When this happens, we temporarily skip these tests to keep our CI green. Later, when we have time, we revisit these skipped tests to fix them. Having a quick command to list these pending tests would make our workflow much simpler.
Right now, we use are considering workaround like this:
ginkgo --json-report report.json --dry-run $(find . -type f -name "*suite_test.go*" -exec dirname "{}" \; | uniq)
We then process the output to find skipped/pending tests (see our attempt here). But this takes ~11 minutes to run on MacBook Pro with M3 Max and 36GB of RAM, which isn't ideal.
A simple proof-of-concept we made that directly parses Go files takes less than 1 second:
Would you consider adding something like a
ginkgo pending
subcommand to list pending/skipped tests? With some guidance we'd be happy to contribute this feature as we've already tested a basic version and it looks straightforward.ginkgo/pending/pending_command.go
Let us know what you think
The text was updated successfully, but these errors were encountered: