Skip to content

Build binary with newer Go Versions? #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vikas027 opened this issue Apr 10, 2025 · 1 comment
Open

Build binary with newer Go Versions? #1454

vikas027 opened this issue Apr 10, 2025 · 1 comment

Comments

@vikas027
Copy link

vikas027 commented Apr 10, 2025

The current Go version in go.mod is 1.17 which has been EOL for quite some time.

It would be great if newer Go version 1.23 or 1.24 can be supported.

I have tried building the amd64 Linux binary, it works fine with with 1.17 but errors out it with 1.22, 1.23 and 1.24.

## Error in Go v1.22 and v1.24
$ make ontology-linux
<redacted>
34.04 smartcontract/service/wasmvm/utils.go:113:11: undefined: WasmjitValidate
34.04 smartcontract/service/wasmvm/wasm_service.go:155:17: undefined: invokeJit
36.00 make: *** [Makefile:39: ontology-linux] Error 1

## Error in Go v1.23
$ make ontology-linux
<redacted>
12.19 github.com/ontio/ontology/vm/neovm/interfaces: /usr/local/go/pkg/tool/linux_amd64/compile: signal: illegal instruction
35.36 make: *** [Makefile:39: ontology-linux] Error 1
@laizy
Copy link
Contributor

laizy commented Apr 10, 2025

We have already built it with Go v1.22 in github action:

go-version: 1.22.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants