Skip to content

Commit bc249c5

Browse files
authored
fix: Release please handle versioning (#47)
Signed-off-by: Nicklas Lundin <[email protected]>
1 parent 4cfef58 commit bc249c5

File tree

4 files changed

+23
-10
lines changed

4 files changed

+23
-10
lines changed

.github/workflows/release_please.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@ jobs:
5858
run: chmod +x gradlew
5959

6060
- name: Build AAR ⚙️🛠
61-
env:
62-
OF_KOTLIN_RELEASE_VERSION: ${{ needs.release-please.outputs.version }}
6361
run: bash ./gradlew :openfeature:assemble
6462

6563
- name: Upload Openfeature SDK AAR 🗳

OpenFeature/build.gradle.kts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ plugins {
77
kotlin("plugin.serialization") version "1.9.10"
88
}
99

10-
val releaseVersion = System.getenv("OF_KOTLIN_RELEASE_VERSION") ?: "0.0.1-SNAPSHOT"
10+
// x-release-please-start-version
11+
val releaseVersion = "0.0.2"
12+
// x-release-please-end
1113

1214
android {
1315
namespace = "dev.openfeature.sdk"

README.md

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,27 +41,36 @@ Note that this library is intended to be used in a mobile context, and has not b
4141

4242
### Install
4343

44+
#### Maven Central
45+
46+
Installation via Maven Central is currently [WIP](https://github.com/open-feature/kotlin-sdk/issues/37)
47+
48+
<!-- x-release-please-start-version -->
49+
You can add the OpenFeature SDK dependency:
50+
```kotlin
51+
dependencies {
52+
api("com.github.open-feature:kotlin-sdk:0.0.2")
53+
}
54+
```
55+
4456
#### Jitpack
4557

4658
The Android project must include `maven("https://jitpack.io")` in `settings.gradle`.
4759

4860
You can now add the OpenFeature SDK dependency:
4961
```kotlin
5062
dependencies {
51-
api("com.github.open-feature:kotlin-sdk:<Latest>")
63+
api("com.github.open-feature:kotlin-sdk:0.0.2")
5264
}
5365
```
54-
Please note that the `<Latest>` can be any `Commit SHA` or a version based on a branch as follows:
66+
<!-- x-release-please-end -->
67+
Please note that the `version` can be any `Commit SHA` or a version based on a branch as follows:
5568
```
5669
api("com.github.open-feature:kotlin-sdk:[ANY_BRANCH]-SNAPSHOT")
5770
```
5871

5972
This will get a build from the head of the mentioned branch.
6073

61-
#### Maven
62-
63-
Installation via Maven Central is currently [WIP](https://github.com/open-feature/kotlin-sdk/issues/37)
64-
6574
### Usage
6675

6776
```kotlin

release-please-config.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@
55
"release-type": "simple",
66
"bump-minor-pre-major": true,
77
"bump-patch-for-minor-pre-major": true,
8-
"versioning": "default"
8+
"versioning": "default",
9+
"extra-files": [
10+
"README.md",
11+
"OpenFeature/build.gradle.kts"
12+
]
913
}
1014
},
1115
"changelog-sections": [

0 commit comments

Comments
 (0)