Skip to content

Commit 410596e

Browse files
authored
Merge pull request #7680 from janjust/oshmem-default-nb-params
oshmem spml ucx: set default nonblocking put/get progress thresholds
2 parents 9b86f14 + 9d26bb0 commit 410596e

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

oshmem/mca/spml/ucx/spml_ucx_component.c

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -162,15 +162,15 @@ static int mca_spml_ucx_component_register(void)
162162
&mca_spml_ucx.synchronized_quiet);
163163

164164
mca_spml_ucx_param_register_ulong("nb_progress_thresh_global", 0,
165-
"Number of nb_put or nb_get operations before ucx progress is triggered. Disabled by default (0)",
165+
"Number of nb_put or nb_get operations before ucx progress is triggered. Disabled by default (0). Setting this value will override nb_put/get_progress_thresh.",
166166
&mca_spml_ucx.nb_progress_thresh_global);
167167

168-
mca_spml_ucx_param_register_ulong("nb_put_progress_thresh", mca_spml_ucx.nb_progress_thresh_global,
169-
"Number of nb_put operations before ucx progress is triggered. Disabled by default (0), setting this value will override nb_progress_thresh_global",
168+
mca_spml_ucx_param_register_ulong("nb_put_progress_thresh", 2048,
169+
"Number of nb_put operations before ucx progress is triggered. Default (2048).",
170170
&mca_spml_ucx.nb_put_progress_thresh);
171171

172-
mca_spml_ucx_param_register_ulong("nb_get_progress_thresh", mca_spml_ucx.nb_progress_thresh_global,
173-
"Number of nb_get operations before ucx progress is triggered. Disabled by default (0), setting this value will override nb_progress_thresh_global ",
172+
mca_spml_ucx_param_register_ulong("nb_get_progress_thresh", 4096,
173+
"Number of nb_get operations before ucx progress is triggered. Default (4096).",
174174
&mca_spml_ucx.nb_get_progress_thresh);
175175

176176
mca_spml_ucx_param_register_ulong("nb_ucp_worker_progress", 32,
@@ -351,6 +351,10 @@ static int spml_ucx_init(void)
351351
mca_spml_ucx.aux_ctx = NULL;
352352
mca_spml_ucx.aux_refcnt = 0;
353353

354+
if (mca_spml_ucx.nb_progress_thresh_global) {
355+
mca_spml_ucx.nb_put_progress_thresh = mca_spml_ucx.nb_progress_thresh_global;
356+
mca_spml_ucx.nb_get_progress_thresh = mca_spml_ucx.nb_progress_thresh_global;
357+
}
354358
if (mca_spml_ucx.nb_put_progress_thresh) {
355359
mca_spml_ucx.super.spml_put_nb = &mca_spml_ucx_put_nb_wprogress;
356360
}

0 commit comments

Comments
 (0)