Skip to content

Commit 616f20c

Browse files
jsquyresjjhursey
authored andcommitted
timer/linux: rename component-specific functions
Several component-specific functions were named with a prefix of "opal_timer_base", which was quite confusing. Rename them to have a prefix "opal_timer_linux" to make it clear that they are here in this component (and different than *actual* opal_timer_base symbols). Signed-off-by: Jeff Squyres <[email protected]>
1 parent 290d459 commit 616f20c

File tree

1 file changed

+21
-18
lines changed

1 file changed

+21
-18
lines changed

opal/mca/timer/linux/timer_linux_component.c

Lines changed: 21 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -33,20 +33,25 @@
3333
#include "opal/constants.h"
3434
#include "opal/util/show_help.h"
3535

36-
static opal_timer_t opal_timer_base_get_cycles_sys_timer(void);
37-
static opal_timer_t opal_timer_base_get_usec_sys_timer(void);
36+
static opal_timer_t opal_timer_linux_get_cycles_sys_timer(void);
37+
static opal_timer_t opal_timer_linux_get_usec_sys_timer(void);
3838

3939
/**
4040
* Define some sane defaults until we call the _init function.
4141
*/
4242
#if OPAL_HAVE_CLOCK_GETTIME
43-
static opal_timer_t opal_timer_base_get_cycles_clock_gettime(void);
44-
static opal_timer_t opal_timer_base_get_usec_clock_gettime(void);
45-
opal_timer_t (*opal_timer_base_get_cycles)(void) = opal_timer_base_get_cycles_clock_gettime;
46-
opal_timer_t (*opal_timer_base_get_usec)(void) = opal_timer_base_get_usec_clock_gettime;
43+
static opal_timer_t opal_timer_linux_get_cycles_clock_gettime(void);
44+
static opal_timer_t opal_timer_linux_get_usec_clock_gettime(void);
45+
46+
opal_timer_t (*opal_timer_base_get_cycles)(void) =
47+
opal_timer_linux_get_cycles_clock_gettime;
48+
opal_timer_t (*opal_timer_base_get_usec)(void) =
49+
opal_timer_linux_get_usec_clock_gettime;
4750
#else
48-
opal_timer_t (*opal_timer_base_get_cycles)(void) = opal_timer_base_get_cycles_sys_timer;
49-
opal_timer_t (*opal_timer_base_get_usec)(void) = opal_timer_base_get_usec_sys_timer;
51+
opal_timer_t (*opal_timer_base_get_cycles)(void) =
52+
opal_timer_linux_get_cycles_sys_timer;
53+
opal_timer_t (*opal_timer_base_get_usec)(void) =
54+
opal_timer_linux_get_usec_sys_timer;
5055
#endif /* OPAL_HAVE_CLOCK_GETTIME */
5156

5257
static opal_timer_t opal_timer_linux_freq = {0};
@@ -171,8 +176,8 @@ int opal_timer_linux_open(void)
171176
struct timespec res;
172177
if( 0 == clock_getres(CLOCK_MONOTONIC, &res)) {
173178
opal_timer_linux_freq = 1.e3;
174-
opal_timer_base_get_cycles = opal_timer_base_get_cycles_clock_gettime;
175-
opal_timer_base_get_usec = opal_timer_base_get_usec_clock_gettime;
179+
opal_timer_base_get_cycles = opal_timer_linux_get_cycles_clock_gettime;
180+
opal_timer_base_get_usec = opal_timer_linux_get_usec_clock_gettime;
176181
return ret;
177182
}
178183
#else
@@ -181,13 +186,13 @@ int opal_timer_linux_open(void)
181186
#endif /* OPAL_HAVE_CLOCK_GETTIME && (0 == OPAL_TIMER_MONOTONIC) */
182187
}
183188
ret = opal_timer_linux_find_freq();
184-
opal_timer_base_get_cycles = opal_timer_base_get_cycles_sys_timer;
185-
opal_timer_base_get_usec = opal_timer_base_get_usec_sys_timer;
189+
opal_timer_base_get_cycles = opal_timer_linux_get_cycles_sys_timer;
190+
opal_timer_base_get_usec = opal_timer_linux_get_usec_sys_timer;
186191
return ret;
187192
}
188193

189194
#if OPAL_HAVE_CLOCK_GETTIME
190-
opal_timer_t opal_timer_base_get_usec_clock_gettime(void)
195+
opal_timer_t opal_timer_linux_get_usec_clock_gettime(void)
191196
{
192197
struct timespec tp = {.tv_sec = 0, .tv_nsec = 0};
193198

@@ -196,7 +201,7 @@ opal_timer_t opal_timer_base_get_usec_clock_gettime(void)
196201
return (tp.tv_sec * 1e6 + tp.tv_nsec/1000);
197202
}
198203

199-
opal_timer_t opal_timer_base_get_cycles_clock_gettime(void)
204+
opal_timer_t opal_timer_linux_get_cycles_clock_gettime(void)
200205
{
201206
struct timespec tp = {.tv_sec = 0, .tv_nsec = 0};
202207

@@ -206,7 +211,7 @@ opal_timer_t opal_timer_base_get_cycles_clock_gettime(void)
206211
}
207212
#endif /* OPAL_HAVE_CLOCK_GETTIME */
208213

209-
opal_timer_t opal_timer_base_get_cycles_sys_timer(void)
214+
opal_timer_t opal_timer_linux_get_cycles_sys_timer(void)
210215
{
211216
#if OPAL_HAVE_SYS_TIMER_GET_CYCLES
212217
return opal_sys_timer_get_cycles();
@@ -216,7 +221,7 @@ opal_timer_t opal_timer_base_get_cycles_sys_timer(void)
216221
}
217222

218223

219-
opal_timer_t opal_timer_base_get_usec_sys_timer(void)
224+
opal_timer_t opal_timer_linux_get_usec_sys_timer(void)
220225
{
221226
#if OPAL_HAVE_SYS_TIMER_GET_CYCLES
222227
/* freq is in MHz, so this gives usec */
@@ -230,5 +235,3 @@ opal_timer_t opal_timer_base_get_freq(void)
230235
{
231236
return opal_timer_linux_freq * 1000000;
232237
}
233-
234-

0 commit comments

Comments
 (0)