Skip to content

Commit 617e89d

Browse files
author
Burlen Loring
committed
fix MCA variable scope in coll ucc
Changes several variables scope from READONLY to ALL so that they can be set via MPI_T interface Signed-off-by: Burlen Loring <[email protected]>
1 parent 25feb3b commit 617e89d

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

ompi/mca/coll/ucc/coll_ucc_component.c

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
/*
33
* Copyright (c) 2021 Mellanox Technologies. All rights reserved.
44
* Copyright (c) 2022 NVIDIA Corporation. All rights reserved.
5+
* Copyright (c) 2024 NVIDIA CORPORATION. All rights reserved.
56
* $COPYRIGHT$
67
*
78
* Additional copyrights may follow
@@ -60,24 +61,24 @@ static int mca_coll_ucc_register(void)
6061
mca_coll_ucc_component_t *cm = &mca_coll_ucc_component;
6162
mca_base_component_t *c = &cm->super.collm_version;
6263
mca_base_component_var_register(c, "priority", "Priority of the UCC coll component",
63-
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
64+
MCA_BASE_VAR_TYPE_INT, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
6465
OPAL_INFO_LVL_9,
65-
MCA_BASE_VAR_SCOPE_READONLY, &cm->ucc_priority);
66+
MCA_BASE_VAR_SCOPE_ALL, &cm->ucc_priority);
6667

6768
mca_base_component_var_register(c, "verbose", "Verbose level of the UCC coll component",
68-
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
69+
MCA_BASE_VAR_TYPE_INT, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
6970
OPAL_INFO_LVL_9,
70-
MCA_BASE_VAR_SCOPE_READONLY, &cm->ucc_verbose);
71+
MCA_BASE_VAR_SCOPE_ALL, &cm->ucc_verbose);
7172

7273
mca_base_component_var_register(c, "enable", "[0|1] Enable/Disable the UCC coll component",
73-
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
74+
MCA_BASE_VAR_TYPE_INT, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
7475
OPAL_INFO_LVL_9,
75-
MCA_BASE_VAR_SCOPE_READONLY, &cm->ucc_enable);
76+
MCA_BASE_VAR_SCOPE_ALL, &cm->ucc_enable);
7677

7778
mca_base_component_var_register(c, "np", "Minimal communicator size for the UCC coll component",
78-
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
79+
MCA_BASE_VAR_TYPE_INT, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
7980
OPAL_INFO_LVL_9,
80-
MCA_BASE_VAR_SCOPE_READONLY, &cm->ucc_np);
81+
MCA_BASE_VAR_SCOPE_ALL, &cm->ucc_np);
8182

8283
mca_base_component_var_register(c, MCA_COMPILETIME_VER,
8384
"Version of the libucc library with which Open MPI was compiled",
@@ -94,14 +95,14 @@ static int mca_coll_ucc_register(void)
9495
cm->cls = "";
9596
mca_base_component_var_register(c, "cls",
9697
"Comma separated list of UCC CLS to be used for team creation",
97-
MCA_BASE_VAR_TYPE_STRING, NULL, 0, 0,
98-
OPAL_INFO_LVL_6, MCA_BASE_VAR_SCOPE_READONLY, &cm->cls);
98+
MCA_BASE_VAR_TYPE_STRING, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
99+
OPAL_INFO_LVL_6, MCA_BASE_VAR_SCOPE_ALL, &cm->cls);
99100

100101
cm->cts = COLL_UCC_CTS_STR;
101102
mca_base_component_var_register(c, "cts",
102103
"Comma separated list of UCC coll types to be enabled",
103-
MCA_BASE_VAR_TYPE_STRING, NULL, 0, 0,
104-
OPAL_INFO_LVL_6, MCA_BASE_VAR_SCOPE_READONLY, &cm->cts);
104+
MCA_BASE_VAR_TYPE_STRING, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
105+
OPAL_INFO_LVL_6, MCA_BASE_VAR_SCOPE_ALL, &cm->cts);
105106
return OMPI_SUCCESS;
106107
}
107108

0 commit comments

Comments
 (0)