[configauth] Deprecate Authentication in favor of AuthenticationConfig #12904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
exporter/otlp
extension/zpages
bogdandrutu
reviewed
Apr 22, 2025
config/configauth/configauth.go
Outdated
| type Authentication = AuthenticationConfig | ||
|
|
||
| // AuthenticationConfig defines the auth settings for the receiver. | ||
| type AuthenticationConfig struct { |
There was a problem hiding this comment.
If we are fine with having to add a more specific name to any other config struct we add to this package that is fine by me
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12904 +/- ##
==========================================
+ Coverage 91.55% 91.65% +0.09%
==========================================
Files 499 499
Lines 27102 27426 +324
==========================================
+ Hits 24814 25138 +324
Misses 1809 1809
Partials 479 479 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecates
configauth.Authenticationin favor ofconfigauth.AuthenticationConfig.Link to tracking issue
Fixes #12875