Skip to content

[mdatagen] Add validation for config serialization #12912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[mdatagen] Add validation for config serialization #12912

wants to merge 5 commits into from
+501 −3

Conversation

Dhruvit96
Copy link

Description

This unit test enhancement ensures that the configuration can be serialized correctly.

Link to tracking issue

Fixes #12906

@Dhruvit96 Dhruvit96 requested a review from a team as a code owner April 23, 2025 05:57
@Dhruvit96 Dhruvit96 requested a review from bogdandrutu April 23, 2025 05:57
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 23, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@Dhruvit96 Dhruvit96 force-pushed the config-serialization-test branch from b11c31d to e08944e Compare April 23, 2025 06:07
@dmathieu
Copy link
Member

Could you add tests? (and fix the failing CI checks)

@Dhruvit96 Dhruvit96 changed the title [mdatagen] Add validation for config serialization [chore][mdatagen] Add validation for config serialization Apr 23, 2025
@Dhruvit96
Copy link
Author

Could you add tests? (and fix the failing CI checks)

I don't think this change requires changelog.
For now I have added chore in PR title but I think it skipped few tests as well, could you please add skip changelog lable?

@dmathieu
Copy link
Member

I think it does require a changelog entry. This changes the behavior of a public method in a public package.

@Dhruvit96 Dhruvit96 changed the title [chore][mdatagen] Add validation for config serialization [mdatagen] Add validation for config serialization Apr 23, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.67%. Comparing base (d020c90) to head (7efced9).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12912      +/-   ##
==========================================
+ Coverage   91.65%   91.67%   +0.02%     
==========================================
  Files         499      499              
  Lines       27426    27450      +24     
==========================================
+ Hits        25138    25166      +28     
+ Misses       1809     1806       -3     
+ Partials      479      478       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dhruvit96 Dhruvit96 force-pushed the config-serialization-test branch 2 times, most recently from 83914a3 to d299e9b Compare April 23, 2025 15:55
@Dhruvit96 Dhruvit96 force-pushed the config-serialization-test branch from d299e9b to 7efced9 Compare April 23, 2025 16:36
@Dhruvit96
Copy link
Author

I have completed all the changes from my end, and the implementation is now ready for review. It should pass all CI checks successfully.

Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner automatically assigned from open-telemetry/collector-approvers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mdatagen] - Add auto-generated tests to verify that the config structure is marshallable
2 participants
@Dhruvit96 @dmathieu