Skip to content

[pdata] Remove pcommon.Value.Equal() #6811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmitryax opened this issue Dec 16, 2022 · 2 comments
Closed

[pdata] Remove pcommon.Value.Equal() #6811

dmitryax opened this issue Dec 16, 2022 · 2 comments

Comments

@dmitryax
Copy link
Member

dmitryax commented Dec 16, 2022

This method should be removed because we don't have the Equal method on other pdata structs and it's used in tests where it can be easily replaced by comparing the results of the AsRaw method.

We don't want to introduce the Equal method on other pdata structures because it's not clear if different orders of pdata slices with the same items should be considered equal. It's not defined in the spec, and we don't want to define that in pdata.

This issue is related to #6688.

@jpkrohling
Copy link
Member

Should this be closed?

@dmitryax
Copy link
Member Author

Should this be closed?

Not yet, let's keep it open for now since if referenced in the code https://github.com/open-telemetry/opentelemetry-collector/pull/6812/files#diff-a0694cfd0d20ad1bb48788b6034d7e47349a86caae7f0db55b88f171c1a8342bR371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants