Prevent NPE (#4527)

iNikem · web-flow · commit 41b5bf999a12 · 2021-10-27T12:54:18.000-07:00
diff --git a/instrumentation/jetty-httpclient/jetty-httpclient-9.2/library/src/main/java/io/opentelemetry/instrumentation/jetty/httpclient/v9_2/internal/JettyHttpClient9TracingInterceptor.java b/instrumentation/jetty-httpclient/jetty-httpclient-9.2/library/src/main/java/io/opentelemetry/instrumentation/jetty/httpclient/v9_2/internal/JettyHttpClient9TracingInterceptor.java
@@ -136,7 +136,9 @@ public void onBegin(Request request) {
     if (this.context != null) {
       Span span = Span.fromContext(this.context);
       HttpField agentField = request.getHeaders().getField(HttpHeader.USER_AGENT);
-      span.setAttribute(SemanticAttributes.HTTP_USER_AGENT, agentField.getValue());
+      if (agentField != null) {
+        span.setAttribute(SemanticAttributes.HTTP_USER_AGENT, agentField.getValue());
+      }
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,9 @@ public void onBegin(Request request) {`
`136`	`136`	`if (this.context != null) {`
`137`	`137`	`Span span = Span.fromContext(this.context);`
`138`	`138`	`HttpField agentField = request.getHeaders().getField(HttpHeader.USER_AGENT);`
`139`		`- span.setAttribute(SemanticAttributes.HTTP_USER_AGENT, agentField.getValue());`
	`139`	`+ if (agentField != null) {`
	`140`	`+ span.setAttribute(SemanticAttributes.HTTP_USER_AGENT, agentField.getValue());`
	`141`	`+ }`
`140`	`142`	`}`
`141`	`143`	`}`
`142`	`144`