Skip to content

Commit 91c3114

Browse files
committed
fix: update tracecontext integration test gitref
Update gitref to latest from https://github.com/w3c/trace-context Skip changed test that is incompatible with our implementation Add fixme comment to track setting flags for the test suite when they are available
1 parent f42041a commit 91c3114

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1515
([#4444](https://github.com/open-telemetry/opentelemetry-python/pull/4444))
1616
- opentelemetry-exporter-opencensus: better dependency version range for Python 3.13
1717
([#4444](https://github.com/open-telemetry/opentelemetry-python/pull/4444))
18+
- Updated `tracecontext-integration-test` gitref to `d782773b2cf2fa4afd6a80a93b289d8a74ca894d`
19+
([#4448](https://github.com/open-telemetry/opentelemetry-python/pull/4448))
1820

1921
## Version 1.30.0/0.51b0 (2025-02-03)
2022

scripts/tracecontext-integration-test.sh

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/bin/sh
22
set -e
33
# hard-coding the git tag to ensure stable builds.
4-
TRACECONTEXT_GIT_TAG="98f210efd89c63593dce90e2bae0a1bdcb986f51"
4+
TRACECONTEXT_GIT_TAG="d782773b2cf2fa4afd6a80a93b289d8a74ca894d"
55
# clone w3c tracecontext tests
66
mkdir -p target
77
rm -rf ./target/trace-context
@@ -24,4 +24,11 @@ onshutdown()
2424
}
2525
trap onshutdown EXIT
2626
cd ./target/trace-context/test
27-
python test.py http://127.0.0.1:5000/verify-tracecontext
27+
28+
# The disabled test is not compatible with an optional part of the W3C
29+
# spec that we have implemented (dropping duplicated keys from tracestate).
30+
# W3C are planning to include flags for optional features in the test suite.
31+
# https://github.com/w3c/trace-context/issues/529
32+
# FIXME: update test to use flags for optional features when available.
33+
export SERVICE_ENDPOINT=http://127.0.0.1:5000/verify-tracecontext
34+
pytest test.py -k "not test_tracestate_duplicated_keys"

tox.ini

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,7 @@ basepython: python3
271271
deps =
272272
# needed for tracecontext
273273
aiohttp~=3.6
274+
pytest==7.4.4
274275
# needed for example trace integration
275276
flask~=2.3
276277
requests~=2.7

0 commit comments

Comments
 (0)