In network adapter metrics, add attribute to indicate protocol type

[sebastien-rosset]

What are you trying to achieve?

Improve the network adapter metrics section. Add attribute to identify the type of network interface, e.g., Ethernet or Fibre Channel.

What did you expect to see?

In the network adapter metrics, I was expecting to find an attribute that identifies the type of adapter, such as "Ethernet" or "Fibre Channel". The hw.type attribute is specified, but its value is set to network, so it's not possible to distinguish between Ethernet versus Fibre Channel or other protocols.

Additional context.

The examples indicate the metrics can be used for Ethernet or Fibre Channel (and presumably other types of network adapters).

A physical network interface, or a network interface controller (NIC), excluding virtual adapters and loopbacks. Examples: an Ethernet adapter, an HBA, an fiber channel port or a Wi-Fi adapter.

Some of the attributes such as id, name, vendor or model may be used as a proxy. However, some adapters are capable of operating in either Fibre Channel mode or Ethernet, so vendor and model are not sufficient. A custom logic would have to be developed.

A standardized attribute for the protocol type would solve this problem.