Skip to content

Fix release scripts, fix windows test bug, add support for derefencing definitions #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 3, 2022

Conversation

jonluca
Copy link
Member

@jonluca jonluca commented Aug 2, 2022

Fixes release scripts and cleans up some types

@jonluca jonluca changed the title Fix release scripts Fix release scripts, fix windows test bug, add support for derefencing definitions Aug 3, 2022
@jonluca
Copy link
Member Author

jonluca commented Aug 3, 2022

One thing that's interesting here is that we had a bit of undefined behavior originally. If a schema had a definitions property (which is valid in JSONSchema), and only some of those entries were referenced, only the referenced ones were converted, leaving the schema in a broken invalid state.

This PR adds a new property (which is true by default, but can be disabled) to convert these definitions as well - convertUnreferencedDefinitions

@philsturgeon philsturgeon merged commit 3544cdb into openapi-contrib:main Aug 3, 2022
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants