Skip to content

Commit 03167ad

Browse files
committed
FIxed UTs
Signed-off-by: Dhwanil Patel <[email protected]>
1 parent ff37a66 commit 03167ad

File tree

2 files changed

+11
-14
lines changed

2 files changed

+11
-14
lines changed

server/src/test/java/org/opensearch/gateway/remote/ClusterMetadataManifestTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public void testClusterMetadataManifestXContent() throws IOException {
3636
Version.CURRENT,
3737
"test-node-id",
3838
false,
39-
1,
39+
ClusterMetadataManifest.CODEC_V0,
4040
null,
4141
Collections.singletonList(uploadedIndexMetadata),
4242
"prev-cluster-uuid",
@@ -53,7 +53,7 @@ public void testClusterMetadataManifestXContent() throws IOException {
5353
}
5454
}
5555

56-
public void testClusterMetadataManifestXContentCodecV2() throws IOException {
56+
public void testClusterMetadataManifestXContentCodecV1() throws IOException {
5757
UploadedIndexMetadata uploadedIndexMetadata = new UploadedIndexMetadata("test-index", "test-uuid", "/test/upload/path");
5858
ClusterMetadataManifest originalManifest = new ClusterMetadataManifest(
5959
1L,
@@ -63,7 +63,7 @@ public void testClusterMetadataManifestXContentCodecV2() throws IOException {
6363
Version.CURRENT,
6464
"test-node-id",
6565
false,
66-
2,
66+
ClusterMetadataManifest.CODEC_V1,
6767
"test-global-metadata-file",
6868
Collections.singletonList(uploadedIndexMetadata),
6969
"prev-cluster-uuid",
@@ -75,7 +75,7 @@ public void testClusterMetadataManifestXContentCodecV2() throws IOException {
7575
builder.endObject();
7676

7777
try (XContentParser parser = createParser(JsonXContent.jsonXContent, BytesReference.bytes(builder))) {
78-
final ClusterMetadataManifest fromXContentManifest = ClusterMetadataManifest.fromXContentV2(parser);
78+
final ClusterMetadataManifest fromXContentManifest = ClusterMetadataManifest.fromXContentV1(parser);
7979
assertEquals(originalManifest, fromXContentManifest);
8080
}
8181
}

server/src/test/java/org/opensearch/gateway/remote/RemoteClusterStateServiceTests.java

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -386,9 +386,9 @@ public void testMigrationFromCodecV0ManifestToCodecV1Manifest() throws IOExcepti
386386
Metadata newMetadata = Metadata.builder(previousClusterState.metadata()).put(indexMetadata, true).build();
387387
ClusterState newClusterState = ClusterState.builder(previousClusterState).metadata(newMetadata).build();
388388

389-
// previous manifest with codec 1 and null global metadata
389+
// previous manifest with codec 0 and null global metadata
390390
final ClusterMetadataManifest previousManifest = ClusterMetadataManifest.builder()
391-
.codecVersion(1)
391+
.codecVersion(ClusterMetadataManifest.CODEC_V0)
392392
.globalMetadataFileName(null)
393393
.indices(Collections.emptyList())
394394
.build();
@@ -402,8 +402,8 @@ public void testMigrationFromCodecV0ManifestToCodecV1Manifest() throws IOExcepti
402402

403403
// global metadata is updated
404404
assertThat(manifestAfterUpdate.getGlobalMetadataFileName(), notNullValue());
405-
// Manifest file with codec version with 2 is updated.
406-
assertThat(manifestAfterUpdate.getCodecVersion(), is(2));
405+
// Manifest file with codec version with 1 is updated.
406+
assertThat(manifestAfterUpdate.getCodecVersion(), is(ClusterMetadataManifest.CODEC_V1));
407407
}
408408

409409
public void testWriteIncrementalGlobalMetadataSuccess() throws IOException {
@@ -626,8 +626,7 @@ public void testReadLatestMetadataManifestSuccessButNoIndexMetadata() throws IOE
626626
.nodeId("nodeA")
627627
.opensearchVersion(VersionUtils.randomOpenSearchVersion(random()))
628628
.previousClusterUUID("prev-cluster-uuid")
629-
.globalMetadataFileName("global-metadata-file")
630-
.codecVersion(1)
629+
.codecVersion(ClusterMetadataManifest.CODEC_V0)
631630
.build();
632631

633632
BlobContainer blobContainer = mockBlobStoreObjects();
@@ -684,8 +683,7 @@ public void testReadLatestMetadataManifestSuccess() throws IOException {
684683
.clusterUUID("cluster-uuid")
685684
.nodeId("nodeA")
686685
.opensearchVersion(VersionUtils.randomOpenSearchVersion(random()))
687-
.globalMetadataFileName("global-metadata")
688-
.codecVersion(1)
686+
.codecVersion(ClusterMetadataManifest.CODEC_V0)
689687
.previousClusterUUID("prev-cluster-uuid")
690688
.build();
691689

@@ -732,8 +730,7 @@ public void testReadLatestIndexMetadataSuccess() throws IOException {
732730
.nodeId("nodeA")
733731
.opensearchVersion(VersionUtils.randomOpenSearchVersion(random()))
734732
.previousClusterUUID("prev-cluster-uuid")
735-
.globalMetadataFileName("global-metadata")
736-
.codecVersion(1)
733+
.codecVersion(ClusterMetadataManifest.CODEC_V0)
737734
.build();
738735

739736
mockBlobContainer(mockBlobStoreObjects(), expectedManifest, Map.of(index.getUUID(), indexMetadata));

0 commit comments

Comments
 (0)