Remove unused methods and switch to modern Java collections

Signed-off-by: Gulshan <[email protected]>

Author: kumargu

libs/agent-sm/agent-policy/src/main/java/org/opensearch/secure_sm/policy/GrantEntry.java

@@ -7,7 +7,6 @@
  */
 package org.opensearch.secure_sm.policy;
 
-import java.io.PrintWriter;
 import java.util.Collections;
 import java.util.LinkedList;
 import java.util.List;
@@ -23,30 +22,4 @@ public void add(PermissionEntry entry) {
     public List<PermissionEntry> permissionElements() {
         return Collections.unmodifiableList(permissionEntries);
     }
-
-    public void write(PrintWriter out) {
-        out.print("grant");
-        if (codeBase != null) {
-            out.print(" Codebase \"");
-            out.print(codeBase);
-            out.print("\"");
-        }
-        out.println(" {");
-        for (PermissionEntry pe : permissionEntries) {
-            out.print("  permission ");
-            out.print(pe.permission);
-            if (pe.name != null) {
-                out.print(" \"");
-                out.print(pe.name);
-                out.print("\"");
-            }
-            if (pe.action != null) {
-                out.print(", \"");
-                out.print(pe.action);
-                out.print("\"");
-            }
-            out.println(";");
-        }
-        out.println("};");
-    }
 }

libs/agent-sm/agent-policy/src/main/java/org/opensearch/secure_sm/policy/PermissionEntry.java

@@ -7,7 +7,6 @@
  */
 package org.opensearch.secure_sm.policy;
 
-import java.io.PrintWriter;
 import java.util.Objects;
 
 public class PermissionEntry {
@@ -29,20 +28,4 @@ public boolean equals(Object obj) {
             && Objects.equals(this.name, that.name)
             && Objects.equals(this.action, that.action);
     }
-
-    public void write(PrintWriter out) {
-        out.print("permission ");
-        out.print(permission);
-        if (name != null) {
-            out.print(" \"");
-            out.print(name.replaceAll("\\\\", "\\\\\\\\").replaceAll("\"", "\\\\\\\""));
-            out.print('"');
-        }
-        if (action != null) {
-            out.print(", \"");
-            out.print(action);
-            out.print('"');
-        }
-        out.println(";");
-    }
 }

libs/agent-sm/agent-policy/src/main/java/org/opensearch/secure_sm/policy/PolicyEntry.java

@@ -15,14 +15,15 @@
 import java.io.IOException;
 import java.io.Reader;
 import java.io.StreamTokenizer;
+import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 import java.util.Optional;
-import java.util.Vector;
 
 public class PolicyParser {
 
-    private final Vector<GrantEntry> grantEntries = new Vector<>();
+    private final List<GrantEntry> grantEntries = Collections.synchronizedList(new ArrayList<>());
+
     private TokenStream tokenStream;
 
     public PolicyParser() {}