Fix: UTs of follower and leader checker

Signed-off-by: Bhumika Sharma <[email protected]>

Author: Bhumika Sharma

CHANGELOG.md

@@ -41,6 +41,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Added File Cache Pinning ([#17617](https://github.com/opensearch-project/OpenSearch/issues/13648))
 - Support consumer reset in Resume API for pull-based ingestion. This PR includes a breaking change for the experimental pull-based ingestion feature. ([#18332](https://github.com/opensearch-project/OpenSearch/pull/18332))
 - Add FIPS build tooling ([#4254](https://github.com/opensearch-project/security/issues/4254))
+- Added FS Health Check Failure metric ([#18435](https://github.com/opensearch-project/OpenSearch/pull/18435))
 
 ### Changed
 - Create generic DocRequest to better categorize ActionRequests ([#18269](https://github.com/opensearch-project/OpenSearch/pull/18269)))

server/src/test/java/org/opensearch/cluster/coordination/FollowersCheckerTests.java

@@ -200,7 +200,7 @@ protected void onSendRequest(long requestId, String action, TransportRequest req
         followersChecker.clearCurrentNodes();
         deterministicTaskQueue.runAllTasks();
         assertThat(checkedNodes, empty());
-        assertEquals(Integer.valueOf(0), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
+        assertEquals(Double.valueOf(0), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
     }
 
     public void testFailsNodeThatDoesNotRespond() {
@@ -215,7 +215,7 @@ public void testFailsNodeThatDoesNotRespond() {
             () -> new StatusInfo(HEALTHY, "healthy-info"),
             metricsRegistry
         );
-        assertEquals(Integer.valueOf(2), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
+        assertEquals(Double.valueOf(2), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
     }
 
     public void testFailsNodeThatRejectsCheck() {
@@ -229,7 +229,7 @@ public void testFailsNodeThatRejectsCheck() {
             () -> new StatusInfo(HEALTHY, "healthy-info"),
             metricsRegistry
         );
-        assertEquals(Integer.valueOf(2), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
+        assertEquals(Double.valueOf(2), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
     }
 
     public void testFailureCounterResetsOnSuccess() {
@@ -259,7 +259,7 @@ public Empty get() {
             () -> new StatusInfo(HEALTHY, "healthy-info"),
             metricsRegistry
         );
-        assertEquals(Integer.valueOf(2), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
+        assertEquals(Double.valueOf(2), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
     }
 
     public void testFailsNodeThatIsDisconnected() {
@@ -272,7 +272,7 @@ public void testFailsNodeThatIsDisconnected() {
             () -> new StatusInfo(HEALTHY, "healthy-info"),
             metricsRegistry
         );
-        assertEquals(Integer.valueOf(2), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
+        assertEquals(Double.valueOf(2), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
     }
 
     public void testFailsNodeThatDisconnects() {
@@ -340,7 +340,7 @@ public String toString() {
         deterministicTaskQueue.runAllRunnableTasks();
         assertTrue(nodeFailed.get());
         assertThat(followersChecker.getFaultyNodes(), contains(otherNode));
-        assertEquals(Integer.valueOf(1), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
+        assertEquals(Double.valueOf(1), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
     }
 
     public void testFailsNodeThatIsUnhealthy() {
@@ -353,7 +353,7 @@ public void testFailsNodeThatIsUnhealthy() {
             () -> new StatusInfo(HEALTHY, "healthy-info"),
             metricsRegistry
         );
-        assertEquals(Integer.valueOf(2), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
+        assertEquals(Double.valueOf(2), metricsRegistry.getCounterStore().get("followers.checker.failure.count").getCounterValue());
     }
 
     private void testBehaviourOfFailingNode(

server/src/test/java/org/opensearch/cluster/coordination/LeaderCheckerTests.java

@@ -233,7 +233,7 @@ public String toString() {
             );
         }
         leaderChecker.updateLeader(null);
-        assertEquals(Integer.valueOf(1), metricsRegistry.getCounterStore().get("leader.checker.failure.count").getCounterValue());
+        assertEquals(Double.valueOf(1), metricsRegistry.getCounterStore().get("leader.checker.failure.count").getCounterValue());
     }
 
     enum Response {
@@ -359,7 +359,7 @@ public String toString() {
             deterministicTaskQueue.runAllRunnableTasks();
             assertTrue(leaderFailed.get());
         }
-        assertEquals(Integer.valueOf(3), metricsRegistry.getCounterStore().get("leader.checker.failure.count").getCounterValue());
+        assertEquals(Double.valueOf(3), metricsRegistry.getCounterStore().get("leader.checker.failure.count").getCounterValue());
     }
 
     public void testFollowerFailsImmediatelyOnHealthCheckFailure() {
@@ -442,7 +442,7 @@ public String toString() {
             assertTrue(leaderFailed.get());
         }
 
-        assertEquals(Integer.valueOf(1), metricsRegistry.getCounterStore().get("leader.checker.failure.count").getCounterValue());
+        assertEquals(Double.valueOf(1), metricsRegistry.getCounterStore().get("leader.checker.failure.count").getCounterValue());
     }
 
     public void testLeaderBehaviour() {
@@ -539,7 +539,7 @@ public void testLeaderBehaviour() {
                 equalTo("rejecting leader check from [" + otherNode + "] sent to a node that is no longer the cluster-manager")
             );
         }
-        assertEquals(Integer.valueOf(0), metricsRegistry.getCounterStore().get("leader.checker.failure.count").getCounterValue());
+        assertEquals(Double.valueOf(0), metricsRegistry.getCounterStore().get("leader.checker.failure.count").getCounterValue());
     }
 
     private class CapturingTransportResponseHandler implements TransportResponseHandler<Empty> {