Skip to content

Commit df7f441

Browse files
committed
Add test for coverage
It's challenging to create a real unit test for this change without constructing a real Lucene index, but at least this invokes the changed code. Signed-off-by: Michael Froh <[email protected]>
1 parent 6c9df4d commit df7f441

File tree

1 file changed

+37
-0
lines changed

1 file changed

+37
-0
lines changed

server/src/test/java/org/opensearch/index/OpenSearchTieredMergePolicyTests.java

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,18 @@
3232

3333
package org.opensearch.index;
3434

35+
import org.apache.lucene.index.MergePolicy;
36+
import org.apache.lucene.index.SegmentCommitInfo;
37+
import org.apache.lucene.index.SegmentInfos;
3538
import org.apache.lucene.index.TieredMergePolicy;
39+
import org.apache.lucene.util.InfoStream;
40+
import org.apache.lucene.util.Version;
3641
import org.opensearch.test.OpenSearchTestCase;
3742

43+
import java.io.IOException;
44+
import java.util.Collections;
45+
import java.util.Set;
46+
3847
public class OpenSearchTieredMergePolicyTests extends OpenSearchTestCase {
3948

4049
public void testDefaults() {
@@ -80,4 +89,32 @@ public void testSetDeletesPctAllowed() {
8089
policy.setDeletesPctAllowed(42);
8190
assertEquals(42, policy.regularMergePolicy.getDeletesPctAllowed(), 0);
8291
}
92+
93+
public void testFindDeleteMergesReturnsNullOnEmptySegmentInfos() throws IOException {
94+
MergePolicy.MergeSpecification mergeSpecification = new OpenSearchTieredMergePolicy().findForcedDeletesMerges(
95+
new SegmentInfos(Version.LATEST.major),
96+
new MergePolicy.MergeContext() {
97+
@Override
98+
public int numDeletesToMerge(SegmentCommitInfo info) {
99+
return 0;
100+
}
101+
102+
@Override
103+
public int numDeletedDocs(SegmentCommitInfo info) {
104+
return 0;
105+
}
106+
107+
@Override
108+
public InfoStream getInfoStream() {
109+
return InfoStream.NO_OUTPUT;
110+
}
111+
112+
@Override
113+
public Set<SegmentCommitInfo> getMergingSegments() {
114+
return Collections.emptySet();
115+
}
116+
}
117+
);
118+
assertNull(mergeSpecification);
119+
}
83120
}

0 commit comments

Comments
 (0)