Skip to content

Commit a69c97a

Browse files
committed
Addressing PR 2 comments.
Signed-off-by: Mitchell Gale <[email protected]>
1 parent dc7998a commit a69c97a

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ spotless {
8787
include 'core/src/main/java/org/opensearch/sql/monitor/**/*.java',
8888
'core/src/main/java/org/opensearch/sql/expression/**/*.java',
8989
'core/src/main/java/org/opensearch/sql/executor/**/*.java',
90-
'core/src/main/java/org/opensearch/sql/exception/**/*.java'
90+
'core/src/main/java/org/opensearch/sql/exception/**/*.java',
9191
'core/src/main/java/org/opensearch/sql/analysis/**/*.java',
9292
'core/src/test/java/org/opensearch/sql/data/**/*.java',
9393
'core/src/test/java/org/opensearch/sql/datasource/**/*.java',

core/src/main/java/org/opensearch/sql/executor/pagination/CanPaginateVisitor.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,12 @@
5252
* Currently, V2 engine does not support queries with:<br>
5353
*
5454
* <ul>
55-
* <li>aggregation (GROUP BY clause or aggregation functions like min/max)
56-
* <li>in memory aggregation (window function)
57-
* <li>LIMIT/OFFSET clause(s)
58-
* <li>without FROM clause
59-
* <li>JOIN
60-
* <li>a subquery
55+
* <li>aggregation (GROUP BY clause or aggregation functions like min/max)</li>
56+
* <li>in memory aggregation (window function)</li>
57+
* <li>LIMIT/OFFSET clause(s)</li>
58+
* <li>without FROM clause</li>
59+
* <li>JOIN</li>
60+
* <li>a subquery</li>
6161
* </ul>
6262
*
6363
* V2 also requires that the table being queried should be an OpenSearch index.<br>

core/src/main/java/org/opensearch/sql/expression/datetime/DateTimeFunction.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1716,10 +1716,10 @@ private ExprValue exprLastDayToday(Clock clock) {
17161716
* Furthermore:<br>
17171717
*
17181718
* <ul>
1719-
* <li>zero year interpreted as 2000
1720-
* <li>negative year is not accepted
1721-
* <li>@dayOfYear should be greater than 1
1722-
* <li>if @dayOfYear is greater than 365/366, calculation goes to the next year(s)
1719+
* <li>zero year interpreted as 2000</li>
1720+
* <li>negative year is not accepted</li>
1721+
* <li>@dayOfYear should be greater than 1</li>
1722+
* <li>if @dayOfYear is greater than 365/366, calculation goes to the next year(s)</li>
17231723
* </ul>
17241724
*
17251725
* @param yearExpr year

core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ private static DefaultFunctionResolver baseMathFunction(
114114
/**
115115
* <b>Definition of abs() function.<\b><br>
116116
* The supported signature of abs() function are<br>
117-
* INT -> INT LONG -> LONG FLOAT -> FLOAT DOUBLE -> DOUBLE
117+
* INT/LONG/FLOAT/DOUBLE -> INT/LONG/FLOAT/DOUBLE
118118
*/
119119
private static DefaultFunctionResolver abs() {
120120
return define(

0 commit comments

Comments
 (0)