Skip to content

Commit f93a82d

Browse files
committed
Addressed comments in PR 5.
Signed-off-by: Mitchell Gale <[email protected]>
1 parent ec7035e commit f93a82d

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

core/src/main/java/org/opensearch/sql/analysis/SelectExpressionAnalyzer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public List<NamedExpression> visitAlias(Alias node, AnalysisContext context) {
7373
* The Alias could be
7474
*
7575
* <ol>
76-
* <li>1. SELECT name, AVG(age) FROM s BY name -> Project(Alias("name", expr), Alias("AVG(age)",
76+
* <li>SELECT name, AVG(age) FROM s BY name -> Project(Alias("name", expr), Alias("AVG(age)",
7777
* aggExpr)) Agg(Alias("AVG(age)", aggExpr))
7878
* <li>SELECT length(name), AVG(age) FROM s BY length(name) Project(Alias("name", expr),
7979
* Alias("AVG(age)", aggExpr)) Agg(Alias("AVG(age)", aggExpr))

core/src/main/java/org/opensearch/sql/ast/dsl/AstDSL.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,23 +249,27 @@ public static Function function(String funcName, UnresolvedExpression... funcArg
249249
}
250250

251251
/**
252-
* CASE<br>
253-
* &emsp; WHEN search_condition THEN result_expr<br>
254-
* &emsp; [WHEN search_condition THEN result_expr] ...<br>
255-
* &emsp; [ELSE result_expr]<br>
252+
* <pre>
253+
* CASE
254+
* WHEN search_condition THEN result_expr<br>
255+
* [WHEN search_condition THEN result_expr] ...
256+
* [ELSE result_expr]
256257
* END
258+
* </pre>
257259
*/
258260
public UnresolvedExpression caseWhen(UnresolvedExpression elseClause,
259261
When... whenClauses) {
260262
return caseWhen(null, elseClause, whenClauses);
261263
}
262264

263265
/**
266+
* <pre>
264267
* CASE case_value_expr
265268
* WHEN compare_expr THEN result_expr
266269
* [WHEN compare_expr THEN result_expr] ...
267270
* [ELSE result_expr]
268271
* END
272+
* </pre>
269273
*/
270274
public UnresolvedExpression caseWhen(UnresolvedExpression caseValueExpr,
271275
UnresolvedExpression elseClause,

0 commit comments

Comments
 (0)