Skip to content

Commit fdd3179

Browse files
Apply suggestions from code review
Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
1 parent 550105b commit fdd3179

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

integ-test/src/test/java/org/opensearch/sql/correctness/runner/resultset/DBResult.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,17 @@
2727
@ToString
2828
public class DBResult {
2929

30-
/** Possible types for floating point number H2 2.x use DOUBLE PRECISION instead of DOUBLE. */
30+
/**
31+
* Possible types for floating point number.<br>
32+
* H2 2.x use DOUBLE PRECISION instead of DOUBLE.
33+
*/
3134
private static final Set<String> FLOAT_TYPES =
3235
ImmutableSet.of("FLOAT", "DOUBLE", "REAL", "DOUBLE PRECISION", "DECFLOAT");
3336

34-
/** Possible types for varchar. H2 2.x use CHARACTER VARYING instead of VARCHAR. */
37+
/**
38+
* Possible types for varchar.<br>
39+
* H2 2.x use CHARACTER VARYING instead of VARCHAR.
40+
*/
3541
private static final Set<String> VARCHAR = ImmutableSet.of("CHARACTER VARYING", "VARCHAR");
3642

3743
/** Database name for display */

integ-test/src/test/java/org/opensearch/sql/legacy/CursorIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ protected void init() throws Exception {
4343

4444
/**
4545
* Acceptable fetch_size are positive numbers. For example 0, 24, 53.0, "110" (parsable string) ,
46-
* "786.23" Negative values should throw 400
46+
* "786.23". Negative values should throw 400.
4747
*/
4848
@Test
4949
public void invalidNegativeFetchSize() throws IOException {

integ-test/src/test/java/org/opensearch/sql/legacy/JSONRequestIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public void search() throws IOException {
3737
SearchHits response =
3838
query(
3939
String.format(
40-
"{\"query\":\"" + "SELECT * " + "FROM %s " + "WHERE age > %s " + "LIMIT 1000\"}",
40+
"{\"query\":\"SELECT * FROM %s WHERE age > %s LIMIT 1000\"}",
4141
TestsConstants.TEST_INDEX_ACCOUNT, ageToCompare));
4242
SearchHit[] hits = response.getHits();
4343
for (SearchHit hit : hits) {

0 commit comments

Comments
 (0)