Skip to content

Commit 2f34420

Browse files
committed
Cleanup: Remove duplicate quantization checks
1 parent 7b13f60 commit 2f34420

File tree

1 file changed

+2
-19
lines changed

1 file changed

+2
-19
lines changed

stablehlo/dialect/Base.cpp

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -751,23 +751,6 @@ bool isValidStablehloQuantizedElementType(Type elementType) {
751751
quantizedPerAxisElementType.getScales().end());
752752
}
753753

754-
// quantized_type_c6
755-
auto maxPosFiniteNum =
756-
APFloat::getLargest(
757-
cast<FloatType>(quantizedElementType.getExpressedType())
758-
.getFloatSemantics())
759-
.convertToDouble();
760-
auto minPosFiniteNum =
761-
APFloat::getSmallest(
762-
cast<FloatType>(quantizedElementType.getExpressedType())
763-
.getFloatSemantics())
764-
.convertToDouble();
765-
if (llvm::any_of(scales, [&](double scale) {
766-
return scale < minPosFiniteNum || scale > maxPosFiniteNum;
767-
})) {
768-
return false;
769-
}
770-
771754
// quantized_type_c7, quantized_type_c8
772755
if (llvm::any_of(zeroPoints, [&](int64_t zeroPoint) {
773756
return storageTypeMin > zeroPoint || zeroPoint > storageTypeMax;
@@ -788,11 +771,11 @@ bool isValidQuantizedDimension(Type type) {
788771

789772
if (!quantizedPerAxisElementType) return true;
790773

791-
// quantized_type_c11, quantized_type_c12, quantized_type_c13
774+
// quantized_type_c12, quantized_type_c13
792775
int64_t quantDim = quantizedPerAxisElementType.getQuantizedDimension();
793776
int64_t numScales =
794777
static_cast<int64_t>(quantizedPerAxisElementType.getScales().size());
795-
return quantDim >= 0 && quantDim < rankedType.getRank() &&
778+
return quantDim < rankedType.getRank() &&
796779
(!rankedType.isDynamicDim(quantDim) &&
797780
numScales == rankedType.getDimSize(quantDim));
798781
}

0 commit comments

Comments
 (0)