Skip to content

Certain changeset properties should be optional #14

Open
@cdauth

Description

@cdauth

First of all, thank you for this awesome library!

By coincidence I experienced an error in my code that handles OSM changesets. It turns out that some changeset properties are optional, despite the TypeScript types of this library (and also the docs of the OSM API) suggesting otherwise. I suspect that this applies to the changesets that were retroactively created for each historical edit when changesets were first introduced.

An example changeset is changeset 123456. In particular, the following properties are missing on it: min_lat, min_lon, max_lat, max_lon, tags. I noticed that there are already comments in the code to make some of these (but not tags) optional in the future, but only because of changesets with open: true.

I think it would be good to mark these properties as optional and leave a comment such as “Missing on some legacy changesets, for example changeset 123456” in the TSDoc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions