Skip to content

False positive detection of binary file for Binary-Artifacts checker #3760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rouault opened this issue Dec 31, 2023 · 4 comments
Open

False positive detection of binary file for Binary-Artifacts checker #3760

rouault opened this issue Dec 31, 2023 · 4 comments
Labels
check/Binary-Artifacts kind/bug Something isn't working

Comments

@rouault
Copy link

rouault commented Dec 31, 2023

Describe the bug
False positive detection of binary file for Binary-Artifacts checker

Reproduction steps

Look at https://securityscorecards.dev/viewer/?uri=github.com/OSGeo/gdal. It indicates in Binary-Artifacts "Warn: binary detected: autotest/gdrivers/data/esric/Layers/_alllayers/L01/R0000C0000.bundle:1"

This is this file: https://github.com/OSGeo/gdal/blob/master/autotest/gdrivers/data/esric/Layers/_alllayers/L01/R0000C0000.bundle

It is a data file used by the regression test suite of the software, not an executable/binary file.

Expected behavior
That file shouldn't be counted as binary artifact

@rouault rouault added the kind/bug Something isn't working label Dec 31, 2023
@spencerschrock
Copy link
Member

We're working on a feature this quarter for maintainers to mark test data as a false positive.

@afmarcum afmarcum moved this to Backlog - Bugs in Scorecard - NEW Mar 5, 2024
@afmarcum afmarcum removed the status in Scorecard - NEW Mar 5, 2024
@afmarcum afmarcum moved this to Backlog - Checks in Scorecard - NEW Mar 5, 2024
@afmarcum afmarcum moved this from Backlog - New Checks to Backlog - Bugs in Scorecard - NEW Mar 7, 2024
@afmarcum
Copy link
Contributor

afmarcum commented Mar 7, 2024

Closing because this will be addressed with the Structured Results feature. We can always revisit if needed.

@afmarcum afmarcum closed this as completed Mar 8, 2024
@github-project-automation github-project-automation bot moved this from Backlog - Bugs to Done in Scorecard - NEW Mar 8, 2024
@rouault
Copy link
Author

rouault commented Mar 19, 2024

@afmarcum Is there some documentation about "Structured Results" how to add an exemption for a false positive binary artifact? Couldn't find any

@afmarcum
Copy link
Contributor

@rouault reopening the issue until Structured Results is released and this issue can be resolved. Targeting early April.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check/Binary-Artifacts kind/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants