Fix #10408

Author: TheOneRing

changelog/unreleased/10408

@@ -5,3 +5,4 @@ error occurred during the retrieval of the credentials from the system's keychai
 The client then required a manual log out and log in.
 
 https://github.com/owncloud/client/issues/10408
+https://github.com/owncloud/client/pull/10505

src/libsync/creds/httpcredentials.cpp

@@ -204,7 +204,7 @@ void HttpCredentials::fetchFromKeychainHelper()
 
     auto job = _account->credentialManager()->get(isUsingOAuth() ? refreshTokenKeyC() : passwordKeyC());
     connect(job, &CredentialJob::finished, this, [job, this] {
-        if (job->error() != QKeychain::NoError) {
+        auto handleError = [job, this] {
             qCWarning(lcHttpCredentials) << "Could not retrieve client password from keychain" << job->errorString();
 
             // we come here if the password is empty or any other keychain
@@ -215,6 +215,9 @@ void HttpCredentials::fetchFromKeychainHelper()
             _password.clear();
             _ready = false;
             emit fetched();
+        };
+        if (job->error() != QKeychain::NoError) {
+            handleError();
             return;
         }
         const auto data = job->data().toString();
@@ -228,8 +231,7 @@ void HttpCredentials::fetchFromKeychainHelper()
                 emit fetched();
             }
         } else {
-            Q_EMIT authenticationFailed();
-            Q_EMIT _account->invalidCredentials();
+            handleError();
         }
     });
 }