SpacesBrowser: Hide already sacned spaces

Fixes: #11752

Author: TheOneRing

changelog/unreleased/11752

@@ -0,0 +1,7 @@
+CHange: Only allow to add unsyced spaces
+
+We now prevent users from syncing the same space multiple times.
+
+
+https://github.com/owncloud/client/issues/11752
+https://github.com/owncloud/client/pull/11759

src/gui/spaces/spacesbrowser.cpp

@@ -27,6 +27,19 @@
 using namespace OCC;
 using namespace OCC::Spaces;
 
+namespace {
+class SpaceFilter : public QSortFilterProxyModel
+{
+    using QSortFilterProxyModel::QSortFilterProxyModel;
+
+    bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const override
+    {
+        auto index = sourceModel()->index(sourceRow, 0, sourceParent);
+        return index.data(static_cast<int>(SpacesModel::Roles::Enabled)).toBool() && !index.data(static_cast<int>(SpacesModel::Roles::IsSynced)).toBool();
+    }
+};
+}
+
 SpacesBrowser::SpacesBrowser(QWidget *parent)
     : QWidget(parent)
     , ui(new Ui::SpacesBrowser)
@@ -35,8 +48,7 @@ SpacesBrowser::SpacesBrowser(QWidget *parent)
     _model = new SpacesModel(this);
 
 
-    _sortModel = new QSortFilterProxyModel(this);
-    _sortModel->setFilterRole(static_cast<int>(SpacesModel::Roles::Enabled));
+    _sortModel = new SpaceFilter(this);
     _sortModel->setSourceModel(_model);
     _sortModel->setSortRole(static_cast<int>(SpacesModel::Roles::Priority));
     _sortModel->sort(0, Qt::DescendingOrder);

src/gui/spaces/spacesmodel.cpp

@@ -13,6 +13,7 @@
  */
 #include "spacesmodel.h"
 
+#include "gui/folderman.h"
 #include "libsync/graphapi/spacesmanager.h"
 
 #include <QIcon>
@@ -38,11 +39,10 @@ QVariant SpacesModel::data(const QModelIndex &index, int role) const
 {
     Q_ASSERT(checkIndex(index, QAbstractItemModel::CheckIndexOption::IndexIsValid));
 
-    const auto *space = _spacesList.at(index.row());
+    auto *space = _spacesList.at(index.row());
     switch (static_cast<Roles>(role)) {
-    case Roles::Sync:
-        // TODO: return true if we alreaddy sync the space
-        return false;
+    case Roles::IsSynced:
+        return FolderMan::instance()->isSpaceSynced(space);
     case Roles::Name:
         return space->displayName();
     case Roles::Subtitle:

src/gui/spaces/spacesmodel.h

@@ -30,7 +30,7 @@ class SpacesModel : public QAbstractListModel
 public:
     enum class Roles {
         AccessibleDescriptionRole = Qt::AccessibleDescriptionRole,
-        Sync = Qt::UserRole + 1,
+        IsSynced = Qt::UserRole + 1,
         Name,
         Subtitle,
         WebUrl,